Skip to content

Commit

Permalink
[#337] Fix list item trailing icon display and vocalization
Browse files Browse the repository at this point in the history
  • Loading branch information
paulinea committed Dec 7, 2022
1 parent 3e2f284 commit e4a069b
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 1 deletion.
1 change: 1 addition & 0 deletions changelog.md
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

### Fixed

- \[Demo\] Fix list item trailing icon vocalization and display ([#337](https://github.com/Orange-OpenSource/ods-android/issues/337))
- \[Lib\] Fix top app bar overflow menu colors ([#349](https://github.com/Orange-OpenSource/ods-android/issues/349))

## [0.8.0](https://github.com/Orange-OpenSource/ods-android/compare/0.7.0...0.8.0) - 2022-12-07
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@ import com.orange.ods.compose.component.list.OdsListItemIconType
import com.orange.ods.compose.component.list.divider
import com.orange.ods.compose.component.list.iconType
import com.orange.ods.compose.text.OdsTextCaption
import com.orange.ods.compose.theme.OdsTheme
import com.orange.ods.demo.R
import com.orange.ods.demo.ui.components.utilities.ComponentCountRow
import com.orange.ods.demo.ui.components.utilities.ComponentCustomizationBottomSheetScaffold
Expand Down Expand Up @@ -177,7 +178,8 @@ private val ListItemCustomizationState.trailing: (@Composable () -> Unit)?
clickOnElement(context, iconText)
},
painter = painterResource(id = R.drawable.ic_info),
contentDescription = null
tint = OdsTheme.colors.onSurface,
contentDescription = stringResource(id = R.string.component_list_information)
)
}
ListItemCustomizationState.Trailing.Caption -> { ->
Expand Down
1 change: 1 addition & 0 deletions demo/src/main/res/values/strings.xml
Original file line number Diff line number Diff line change
Expand Up @@ -224,6 +224,7 @@
<string name="component_list_trailing_icon">Icon</string>
<string name="component_list_trailing_caption">Caption</string>
<string name="component_list_divider">Divider</string>
<string name="component_list_information">Information</string>

<!-- Component Snackbars -->
<string name="component_snackbars">Snackbars</string>
Expand Down

0 comments on commit e4a069b

Please sign in to comment.