This repository has been archived by the owner on Oct 20, 2022. It is now read-only.
liveness - Make separate liveness/readiness probes possible. #278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By default, the same script will continue to be used for both probes, since liveness-probe.sh is a symlink to readiness-probe.sh. However, by using separate filenames for each of the probes, it is now possible to override this behavior, and define separate scripts for each type of probe.
|
For the dgoss test to pass, this will require building a new bootstrap docker image (version 0.1.7). |
|
I wanted to simplify it but I think it makes sense if you want to overwrite it. I’ll generate the bootstrap image and kick off the tests again |
cscetbon
approved these changes
Nov 16, 2020
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
This PR adds back the ability to use different scripts for the liveness and readiness probes, but it preserves the default behavior (introduced in #234) where the same script is used for both.
The
readiness-probe.shscript will continue to be used for both the liveness and readiness probes, sinceliveness-probe.shis a symlink toreadiness-probe.sh.However, by using separate filenames for each of the probes, it is now possible to override this behavior, and define separate scripts for each type of probe.
Checklist