Skip to content
This repository has been archived by the owner on Oct 20, 2022. It is now read-only.

Backup with file protocol failed if secret is not set #378

Closed
AKamyshnikova opened this issue Nov 1, 2021 · 0 comments · Fixed by #379
Closed

Backup with file protocol failed if secret is not set #378

AKamyshnikova opened this issue Nov 1, 2021 · 0 comments · Fixed by #379

Comments

@AKamyshnikova
Copy link
Contributor

Bug Report

What did you do?
Use file protocol for backup location without setting secret name.

What did you expect to see?
As described in instaclustr README file protocol does not require authentication, so backup should be created successfully.

What did you see instead? Under which circumstances?
Backup failed with BackupFailedSecretNotFound

Environment

  • casskop version: casskop:v2.0.2-release

Possible Solution
Check for file protocol type, before validating secret.
@AKamyshnikova AKamyshnikova mentioned this issue Nov 1, 2021
Merged
cscetbon pushed a commit that referenced this issue Dec 12, 2021
@AKamyshnikova
[Backup] Do not validate Secret for file protocol (#379)
82bcb0c 
File protocol does not need any authentication, but backup will
fail if secret is not set.

Fixes #378
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Backup] Do not validate Secret for file protocol
1 participant
@AKamyshnikova