Fix (scrollspy): Replace navbar and nested nav examples #923
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Signed-off-by: Isabelle Chanclou <isabelle.chanclou@orange.com>
Signed-off-by: Isabelle Chanclou <isabelle.chanclou@orange.com>
Signed-off-by: Isabelle Chanclou <isabelle.chanclou@orange.com>
… nav Signed-off-by: Isabelle Chanclou <isabelle.chanclou@orange.com>
Signed-off-by: Isabelle Chanclou <isabelle.chanclou@orange.com>
isabellechanclou
force-pushed
the
main-isabellechanclou-scrollspy
branch
from
a67b85c
to
934e65b
Compare
Signed-off-by: Isabelle Chanclou <isabelle.chanclou@orange.com>
|
@isabellechanclou: commit 5b15430 proposes some fixes and enhancement regarding the re-usability of this alert. |
julien-deramond
approved these changes
Dec 10, 2021
|
@Lausselloic Do you want to look at it? |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The 2 examples concerned in the issue shall be modified. In Bootstrap 5 and so far in Boosted 5, they are based on
navbar(horizontal and vertical) component. As these cases don't exist in Orange Design system, here's a first proposal for replacing these 2 new examples based this time onnavcomponent.Preview: https://deploy-preview-923--boosted.netlify.app/docs/5.1/components/scrollspy/