Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(footerExample): Adding a footer example #922

Merged
merged 12 commits into from
Dec 8, 2021
Merged

feat(footerExample): Adding a footer example #922

merged 12 commits into from
Dec 8, 2021

Conversation

louismaximepiton
Copy link
Member

@louismaximepiton louismaximepiton commented Nov 19, 2021 •
edited
Loading

@louismaximepiton louismaximepiton changed the title Adding a footer example feat(footerExample): Adding a footer example Nov 19, 2021
@louismaximepiton louismaximepiton linked an issue Nov 19, 2021 that may be closed by this pull request
Display a first version of the Footer in Examples #919
Closed
@louismaximepiton louismaximepiton mentioned this pull request Nov 23, 2021
Open
20 tasks
@louismaximepiton
feat(footerExample): Adding example
b5f03fc 
Signed-off-by: louismaximepiton <louismaxime.piton@orange.com>
@louismaximepiton
Add Footers to examples
983a789 
Signed-off-by: louismaximepiton <louismaxime.piton@orange.com>
julien-deramond
julien-deramond requested changes Dec 6, 2021
View reviewed changes
Copy link
Member

@julien-deramond julien-deramond left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great while waiting for a real component: it offers an alternative for the projects that can't wait.

Maybe we should try to use the same wording and examples than in https://system.design.orange.com/0c1af118d/p/20e9fb-footer/b/9571c3/i/66611056 (no Lorem Ipsum, same words at the same place, etc.); it would be easier to review in the future.

There is a conflict that must be resolved.

site/content/docs/5.1/examples/footers/index.html Outdated Show resolved Hide resolved
site/content/docs/5.1/examples/footers/index.html Outdated Show resolved Hide resolved
site/content/docs/5.1/examples/footers/index.html Outdated Show resolved Hide resolved
site/content/docs/5.1/components/orange-footer.md Outdated Show resolved Hide resolved
site/content/docs/5.1/examples/footers/index.html Outdated Show resolved Hide resolved
@julien-deramond
Copy link
Member

julien-deramond commented Dec 7, 2021 •
edited
Loading

9516ff5 + 4f47d8f are a proposal to improve the understanding of the extra CSS. I propose to embed it directly in the footer.css so that we have the correct rendering in the example. While reading the doc, the developers can copy it if needed. IMO, it is easier to understand. If you disagree, you can remove those 2 commits and we'll find another way to tackle this.

julien-deramond and others added 3 commits December 7, 2021 07:30
@julien-deramond
.
4f47d8f
@julien-deramond
.
b4abdc0
@louismaximepiton
Minor fixes
54d1307 
Signed-off-by: louismaximepiton <louismaxime.piton@orange.com>
@julien-deramond julien-deramond merged commit b4b7ea1 into main Dec 8, 2021
@julien-deramond julien-deramond deleted the main-lmp-footer-examples branch December 8, 2021 12:51
This was referenced Dec 8, 2021
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julien-deramond julien-deramond julien-deramond approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Display a first version of the Footer in Examples
2 participants
@louismaximepiton @julien-deramond