-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(titlesColor): Fixed utilities' primary color #872
Conversation
2d401a7
to
908434e
Compare
908434e
to
78872fb
Compare
This comment was marked as resolved.
This comment was marked as resolved.
✅ Deploy Preview for boosted ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
In Helpers > Colored links we have orange on black bg. So the orange should be "Brand orange" instead of "Accessible orange" IMO. |
At some point (maybe not in this PR) we could maybe say in Utilities > Color that |
While I'm checking for
|
I'd think so too, but I feel actually really weird using them with an incoming background. If the background is set by the user (using
Would be great for accessibility ! |
Signed-off-by: louismaximepiton <louismaxime.piton@orange.com>
Signed-off-by: louismaximepiton <louismaxime.piton@orange.com>
Signed-off-by: louismaximepiton <louismaxime.piton@orange.com>
b4dba7b
to
44ef23b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've spotted an issue with our spinners that use text-primary
to define the color so our orange spinners now use #f16e00
instead of #ff7900
(DSM guidelines reference)
|
Returns from the spec review: the spinners should be |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just before merging, discovered that https://deploy-preview-872--boosted.netlify.app/docs/5.2/utilities/colors/#opacity doesn't work anymore
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
Fix #815: Color of text utilities from #ff7900 to #f16e00 on white backgrounds
Netlify : https://deploy-preview-872--boosted.netlify.app/docs/5.2/utilities/colors/