Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix focus-visible import #673

Merged
merged 8 commits into from
Dec 20, 2021
Merged

fix focus-visible import #673

merged 8 commits into from
Dec 20, 2021

Conversation

Lausselloic
Copy link
Member

fix(focus-visible): fix focus-visible import in boosted.js and remove focus-visible from peer-dependencies

fix #672

Copy link
Member

@julien-deramond julien-deramond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK for this modification.

Because we haven't reviewed it quickly, maybe rebase it and check if the bundlewatch new values are still coherent.

Just a question because I don't know much about "jspm", you don't need to remove the focus-visible dependency as well in the following section in package.json?

"jspm": {
    "registry": "npm",
    "main": "js/boosted",
    "directories": {
      "lib": "dist"
    },
    "shim": {
      "js/boosted": {
        "deps": [
          "focus-visible",
          "jquery",
          "popper.js",
          "tablesorter",
          "swiper"
        ],
        "exports": "$"
      }
    },
    "dependencies": {},
    "peerDependencies": {
      "focus-visible": "^5.2.0",
      "jquery": "1.9.1 - 3",
      "popper.js": "^1.16.1",
      "tablesorter": "^2.31.3",
      "swiper": "^6.5.1"
    }
  }

@julien-deramond
Copy link
Member

I propose to remove as well focus-visible from jspm which works like npm from what I have understood. @Lausselloic if you are OK with it, I can merge this PR.

@julien-deramond julien-deramond merged commit fdd398c into v4-dev Dec 20, 2021
@julien-deramond julien-deramond deleted the fix-focus-visible-import branch December 20, 2021 10:39
@julien-deramond julien-deramond mentioned this pull request Dec 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

focus-within import in boosted 4.6.0 doesn't work outside the bundle
2 participants