-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix focus-visible import #673
Conversation
…ve `focus-visible` from peer-dependencies
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK for this modification.
Because we haven't reviewed it quickly, maybe rebase it and check if the bundlewatch new values are still coherent.
Just a question because I don't know much about "jspm", you don't need to remove the focus-visible
dependency as well in the following section in package.json?
"jspm": {
"registry": "npm",
"main": "js/boosted",
"directories": {
"lib": "dist"
},
"shim": {
"js/boosted": {
"deps": [
"focus-visible",
"jquery",
"popper.js",
"tablesorter",
"swiper"
],
"exports": "$"
}
},
"dependencies": {},
"peerDependencies": {
"focus-visible": "^5.2.0",
"jquery": "1.9.1 - 3",
"popper.js": "^1.16.1",
"tablesorter": "^2.31.3",
"swiper": "^6.5.1"
}
}
I propose to remove as well |
fix(focus-visible): fix focus-visible import in
boosted.js
and removefocus-visible
from peer-dependenciesfix #672