Prepare 5.0.0-beta3

[klediouron]

• Bootstrap v5.0.0-beta3 release: https://github.com/twbs/bootstrap/releases/tag/v5.0.0-beta3
• Bootstrap blog post: https://blog.getbootstrap.com/2021/03/23/bootstrap-5-beta-3/

---

Preview : https://deploy-preview-650--boosted.netlify.app/

---

• Run linters;
• Run compilers;
• Run tests;
• Check documentation site: examples and contents;
• Test cross-browser compatibility locally and with BrowserStack:
  • Firefox ESR
  • Latest Edge, Chrome, Firefox, Safari
  • iOS Safari
  • Chrome & Firefox on Android
• Including RTL mode;
• sync with Bootstrap's release and probably wait for it;
• npm run release-version $current_version $next_version to bump version number
  • if bumping a minor or major version → still v5.0
• npm run release to compile dist, update SRI hashes in doc and package the release
• Prepare changelog:
  • install Conventionnal Changelog and conventional-changelog-cli globally
  • run conventional-changelog -p angular -i CHANGELOG.md -s
  • Ship list: v5.0.0 beta2 Ship List #585
• commit and push dist with a chore(release) commit message
• merge on v5-dev
• tag your version, and push your tag
• create a GitHub release:
  • attach zip file
  • paste CHANGELOG or Ship List in the release's description
• We don't publish v5.0 docs yet
• npm pack then npm publish
  • if you are already logged in NPM (with a personnal account, for example), you'd better use a repository scoped .npmrc file
  • if you're releasing a pre-release, use --tag, eg for v5-alpha1 npm publish boosted-5.0.0-alpha1.tgz --tag next
• check release on NPM, Packagist…
• make an announcement in Plazza 🎉

[github-actions]

Images automagically compressed by Calibre's image-actions ✨

Compression reduced images by 4.3%, saving 6.45 KB.

Filename	Before	After	Improvement	Visual comparison
site/content/docs/5.0/examples/features/unsplash-photo-2.jpg	110.37 KB	104.73 KB	-5.1%	View diff
site/content/docs/5.0/examples/features/unsplash-photo-3.jpg	39.66 KB	38.85 KB	-2.0%	View diff

81 images did not require optimisation.

Update required: Update image-actions configuration to the latest version before 1/1/21. See README for instructions.

[github-actions]

Images automagically compressed by Calibre's image-actions ✨

Compression reduced images by 4.3%, saving 6.45 KB.

Filename	Before	After	Improvement	Visual comparison
site/content/docs/5.0/examples/features/unsplash-photo-2.jpg	110.37 KB	104.73 KB	-5.1%	View diff
site/content/docs/5.0/examples/features/unsplash-photo-3.jpg	39.66 KB	38.85 KB	-2.0%	View diff

81 images did not require optimisation.

Update required: Update image-actions configuration to the latest version before 1/1/21. See README for instructions.

[github-actions]

Images automagically compressed by Calibre's image-actions ✨

Compression reduced images by 4.3%, saving 6.45 KB.

Filename	Before	After	Improvement	Visual comparison
site/content/docs/5.0/examples/features/unsplash-photo-2.jpg	110.37 KB	104.73 KB	-5.1%	View diff
site/content/docs/5.0/examples/features/unsplash-photo-3.jpg	39.66 KB	38.85 KB	-2.0%	View diff

81 images did not require optimisation.

Update required: Update image-actions configuration to the latest version before 1/1/21. See README for instructions.

[Lausselloic]

• some sample need brand alignement. Maybe fix the design on accordions and create other PR for Orange branded samples
• no need to add dist files in this MR only for release, not sure if this PR is intended to be the release or just the bootstrap merge
• What's that new dist/css/boosted-rtl.rtl.css.map? Is there a merge side effect that produce new files?
• before release need to change the boosted version in _config.yml but not at time (if this PR is not for release)

[julien-deramond]

The commit https://github.com/twbs/bootstrap/pull/33401/files is listed in https://github.com/twbs/bootstrap/releases/tag/v5.0.0-beta3 but I don't see this modification in this PR.

Am I wrong or we could use https://img.shields.io/github/workflow/status/Orange-OpenSource/Orange-Boosted-Bootstrap/JS%20Tests/v5-dev?label=JS%20Tests&logo=github in our README.md too?

And when V5 will be the main branch of Boosted, modify it in https://img.shields.io/github/workflow/status/Orange-OpenSource/Orange-Boosted-Bootstrap/JS%20Tests/main?label=JS%20Tests&logo=github.

[julien-deramond]

build/ship.sh has been deleted in Bootstrap via https://github.com/twbs/bootstrap/pull/33326/files and it is not deleted in this PR.
It is mentioned in https://github.com/Orange-OpenSource/Orange-Boosted-Bootstrap/wiki/DoD-for-release but shouldn't it be deleted as well and possibly copy those commands in the Wiki?
Or if this script is useful, maybe rename it so that it is clear that it belongs only to Boosted?

[ffoodd]

My two cents:

• drop the build/ship.sh, it basically only copies the docs out of the repo to ease switching ti gh-pages branch. Can be done manually.
• example customization to apply Orange brand is tracked in a specific issue, no hurry on those.
• list group is not tracked by the brand as they don't use it: keep it as-is, without asking them (if it's not too late :D)
• check accordions through Percy, it's crying already… and make it pass!

[julien-deramond]

This is my 1st Boosted code review, so take my comments cautiously 😇

• 4c7a3e8adf adds Sass docs (variables, mixins, and loops) to most pages. Some of them specific to Boosted aren't they missing? I'm thinking about @each $name in map-keys($btn-social-networks) { in _button.scss for example.
• d4e6b973 This PR doesn't modify config.yml:
  • Still references beta2 instead of beta3
  • popper and popper_hash are not modified for example
• I'm sad to see "List group" disappear. Can't we keep it? It must be used by projects in 4.6.
• The problem with the Accordions has already been mentionned by Loïc

[ffoodd]

Regarding Pa11y, would you mind re-running the action? Some paged time out.
New errors all came up with Bootstrap's new examples, I'll try to fix them upstream—you may want to ignore them for now.

And Percy only shows a single change, where it was previously missing a snapshot. IMHO you're safe to approve the build :)

[ffoodd]

Pa11y errors should be covered in Bootstrap #33772, please check its status.

Some won't so you'll have to ignore them the most specifically you can (e.g. maybe try to disable a test only on specific URLs? Not sure it is possible) — or you'll need to override Boosted's example to fix examples in this repo.

[Lausselloic]

From where are comming new files *-rtl.rtl*? They weren't in the repo before that merge

[klediouron]

> From where are comming new files *-rtl.rtl*? They weren't in the repo before that merge

It seems that is the case in bootstrap too https://github.com/twbs/bootstrap/pull/33439/files

Very wrong...

[ffoodd]

Nope, there's no such files (look closer at *-rtl.rtl). There's no boosted-rtl.scss source so you shouldn't have boosted-rtl.css : my bet is some v4 leftovers when switching to v5.

Maybe add thos files to .gitignore? But for now you need to remove them from this PR :)

[Lausselloic]

added file removed and dist regenerated with my last commit