Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Carousels #573

Merged
merged 11 commits into from
Jan 5, 2021
Merged

Carousels #573

merged 11 commits into from
Jan 5, 2021

Conversation

ffoodd
Copy link
Contributor

@ffoodd ffoodd commented Nov 20, 2020

Closes #550, closes #551

To-do

  • Check if we can set an animation for "in progress" state, probably using an inline custom property for both animation-duration and animation-play-state (on :hover).
    • use a prefix for --carousel-interval, and probably extend this to all boosted-only custom props — using a variable prefix?
  • Carousel controls
  • Disable prev/next controls when not going to wrap
  • Get things done by adding pause button? (Carousel improvements #366)
  • Dark variant → dropped
  • JS tests (!)
    • .paused should be added on mouseenter, removed on mouseleave
    • .done should be added when last slide and data-bs-wrap="false"
    • --o-carousel-interval should be set on indicator when data-bs-interval is provided
  • What should be documented?
    • Pagination dots added in Design Guidelines, at least
    • Document the behaviour using custom property (with custom prefix?) and new .paused / .done classes?
    • New target-size() mixin Somewhere?
    • All of those in the migration guide issue (v5 — migration guide #383)
  • Should the animated progress indicator be a variant?
  • Test in RTL (!) → JS seems good, CSS animation is wrong so far
  • Add more JS tests (!)
  • static carousel uses data-bs-interval="false"? Bootstrap #32640 comment
  • improve target-size():
    • dissociate width and height
    • use 44px equivalent as default size
    • set minimum width and height matching parent's, or try min-content and other keywords?
  • cross-browser testing

Preview: https://deploy-preview-573--boosted.netlify.app/docs/5.0/components/carousel/ ("with indicators", "Individual .carousel-item interval", "Prevent cycling", "Static carousel")

@ffoodd ffoodd added this to the 5.0.0-beta milestone Nov 20, 2020
@ffoodd ffoodd self-assigned this Nov 20, 2020
@ffoodd ffoodd changed the title feat(carousel)[WIP]: Orange branded 🎉 Pagination Dots Nov 20, 2020
@ffoodd ffoodd force-pushed the feature/pagination-dots branch 2 times, most recently from 4f9c82b to f39ade2 Compare November 23, 2020 09:19
@ffoodd ffoodd mentioned this pull request Nov 23, 2020
@ffoodd ffoodd mentioned this pull request Dec 15, 2020
4 tasks
@ffoodd ffoodd force-pushed the feature/pagination-dots branch 2 times, most recently from 3d830c0 to 5df6d34 Compare December 15, 2020 16:15
@ffoodd ffoodd changed the title Pagination Dots Carousels Dec 15, 2020
@ffoodd ffoodd force-pushed the feature/pagination-dots branch 6 times, most recently from ef91b08 to ecf2f53 Compare December 18, 2020 10:39
@ffoodd ffoodd mentioned this pull request Dec 18, 2020
10 tasks
@ffoodd
Copy link
Contributor Author

ffoodd commented Dec 18, 2020

Maybe something to improve progress indicator's animation: https://twitter.com/anatudor/status/1340051011323486209

@ffoodd
Copy link
Contributor Author

ffoodd commented Jan 5, 2021

Finally cannot be backported to v4 since we rely on mask-image and advanced animations.

@ffoodd ffoodd marked this pull request as ready for review January 5, 2021 10:37
@ffoodd ffoodd mentioned this pull request Jan 5, 2021
@ffoodd ffoodd merged commit 6671a9a into v5-dev Jan 5, 2021
@ffoodd ffoodd deleted the feature/pagination-dots branch January 5, 2021 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant