[OUDS] feat(css): Drop form-star-rating() mixin
#2635
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julien-deramond
added
feature
docs
julien-deramond
changed the title
form-star-rating() mixinform-star-rating() mixin
julien-deramond
changed the title
form-star-rating() mixinform-star-rating() mixin
✅ Deploy Preview for boosted ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issues
Listed in #2589
Description
form-star-rating()mixin has been deprecated in Boosted v5.3.2. Since this library starts from scratch, there is no need to start with it. However, this must be mentioned in the migrating guide from Boosted.Plus, the other elements that are deprecated and that use the
deprecate()mixin are all from Bootstrap (because Boosted didn't deprecate really elements back then and deleted them directly): https://github.com/search?q=repo%3AOrange-OpenSource%2FOrange-Boosted-Bootstrap+%22%40include+deprecate%28%22&type=codeSo, let's consider that
deprecate()is a mixin dedicated to Bootstrap elements, as it will be easier to maintain.If we need a deprecation mixin for OUDS Web elements, we will create a new one.
In order to make the Bootstrap deprecation mixin clearer, "Bootstrap" string has been added to the sentences.
Types of change
Live previews