Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Micro anim on docs guidelines page #2379

Merged
merged 2 commits into from
Nov 27, 2023

Conversation

louismaximepiton
Copy link
Member

Description

Add a micro animation as there was before on the DSM.
Anyway the color change might be done on dark mode branch.

Previews

@louismaximepiton louismaximepiton added v5 docs Improvements or additions to documentation enhancement labels Nov 14, 2023
Copy link

netlify bot commented Nov 14, 2023

Deploy Preview for boosted ready!

Name Link
🔨 Latest commit f0379a1
🔍 Latest deploy log https://app.netlify.com/sites/boosted/deploys/65644e6c10faaa0008425338
😎 Deploy Preview https://deploy-preview-2379--boosted.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@louismaximepiton louismaximepiton changed the title Micro anim on docs guidelines page Docs: Micro anim on docs guidelines page Nov 14, 2023
@julien-deramond
Copy link
Member

Can you please check with the designers that it's something they want. We generally don't have animations; not that they are not wanted, but rather because we don't have any rules about animations anywhere.
We should keep the previous color in this PR because we're not sure this custom property will be actually used even in the dark mode branch. Let's keep something consistent in the main branch.

@julien-deramond
Copy link
Member

This micro animation has been validated by the designers. I let you check the comments in order to finalize this PR and merge it @louismaximepiton.

Copy link
Member

@julien-deramond julien-deramond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@julien-deramond julien-deramond merged commit 2f3e539 into main Nov 27, 2023
17 of 18 checks passed
@julien-deramond julien-deramond deleted the main-lmp-micro-anim-guidelines branch November 27, 2023 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to documentation enhancement passed design review v5
Projects
Development

Successfully merging this pull request may close these issues.

2 participants