-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add Icons rendering section #2217
docs: add Icons rendering section #2217
Conversation
✅ Deploy Preview for boosted ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we could add an icon less "rounded"? Maybe tick and/or delete? The size difference would be more obvious...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's great to have theses explanations... Some comments:
- Maybe we could add an icon less "rounded"? Maybe tick and/or buy? The size difference will be more obvious...
- Icons rendering could be a level 2 title directly after the introduction of the page regarding PR Docs: enhance doc for Solaris icons #2075
- I would add a little bit more explanations eg:
Icons are created in a square layout to maintain consistency. This square contains a safety zone that allows the icons to be used in different sizes and contexts and still be aligned as the designers wish. The size of the icons includes this safety zone.
cb21121
to
d1c40d9
Compare
Thanks for your comment @hannahiss! It's been taken into account in d362d15. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there exists => there is ?
2 times ensure/ensuring => there is a designated safety zone to ensure that icons can be used in various sizes and contexts while keeping alignment as intended by the designers ?
5d9730f
to
570b92c
Compare
Description
This PR adds a section explaining how icons are built/rendered within a square and with a safe zone.
Motivation & Context
In projects, we are often wondering whether this safe zone is normal or not. Some designers in the projects remove them, some keep them. The purpose here is to fix this rule in our documentation.
Types of change
Live previews
Checklist
Contribution
Documentation