Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(docs): update broken DSM links #2126

Merged
merged 1 commit into from
Jul 4, 2023
Merged

Conversation

julien-deramond
Copy link
Member

@julien-deramond julien-deramond commented Jul 4, 2023

Related issues

This PR fixes some broken DSM links.

Live previews

@julien-deramond julien-deramond added v5 docs Improvements or additions to documentation fix labels Jul 4, 2023
@sonarcloud
Copy link

sonarcloud bot commented Jul 4, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@netlify
Copy link

netlify bot commented Jul 4, 2023

Deploy Preview for boosted ready!

Name Link
🔨 Latest commit c643720
🔍 Latest deploy log https://app.netlify.com/sites/boosted/deploys/64a4149a61b734000877f90e
😎 Deploy Preview https://deploy-preview-2126--boosted.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@MewenLeHo MewenLeHo self-requested a review July 4, 2023 12:50
Copy link
Contributor

@MewenLeHo MewenLeHo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch 👍

I think it's coming from the design description we made for the design team: progress indicators were then splitted into progress bars and spinners in the DSM, exactly like that we have in our doc.

So we may have broken links in the incoming callouts for the spinners part too.

@julien-deramond julien-deramond merged commit f78ebfd into main Jul 4, 2023
@julien-deramond julien-deramond deleted the main-jd-update-dsm-links branch July 4, 2023 12:55
@julien-deramond julien-deramond mentioned this pull request Jul 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to documentation fix v5
Projects
Development

Successfully merging this pull request may close these issues.

2 participants