Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workflows: Add automation for github project to pass an approved PR directly in good column #2092

Merged
merged 8 commits into from
Aug 28, 2023

Conversation

louismaximepiton
Copy link
Member

@louismaximepiton louismaximepiton commented Jun 19, 2023

Note: Please transform - [ ] into - (NA) in the description when things are not applicable

Related issues

NA

Description

When a PR is approved while needing either a design review, or an a11y review or both, the label of the PR needs to be updated and the associated card should move in the Need Design/A11y Review column.
When a PR is approved while not needing any design or a11y review, the associated card should move in the Need Lead Dev Review column.

⚠️ After the PR is merged, we might need to update a bit the project workflows to remove the code review approved behavior.

Motivation & Context

Fully automate the new board.

Types of change

  • New feature (non-breaking change which adds functionality)

@louismaximepiton louismaximepiton added v5 skip-changelog github_actions Pull requests that update Github_actions code labels Jun 19, 2023
@netlify
Copy link

netlify bot commented Jun 19, 2023

Deploy Preview for boosted ready!

Name Link
🔨 Latest commit bd70351
🔍 Latest deploy log https://app.netlify.com/sites/boosted/deploys/64ec6b2beca48e0008b97288
😎 Deploy Preview https://deploy-preview-2092--boosted.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@sonarcloud
Copy link

sonarcloud bot commented Jun 23, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

MewenLeHo

This comment was marked as outdated.

MewenLeHo

This comment was marked as outdated.

@julien-deramond julien-deramond merged commit 246b4a4 into main Aug 28, 2023
44 checks passed
@julien-deramond julien-deramond deleted the main-lmp-add-approved-workflow branch August 28, 2023 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
github_actions Pull requests that update Github_actions code skip-changelog v5
Projects
Development

Successfully merging this pull request may close these issues.

3 participants