-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
YouTube: Change url to avoid cookies from YouTube. #2089
Conversation
✅ Deploy Preview for boosted ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure if it's working correctly, could you please check so I can finish this review?
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As discussed together, it seems that the issue comes from the cookie settings of the browser (if I accept them all I don't have the issue anymore). This looks like a netlify issue. |
I would add that we found this problem using Chrome in private mode. It seems to works fine with other browsers, even in private navigation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. No more cookies on Chrome with normal navigation. The video is still displayed correctly.
Turning on the Privacy Enhanced Mode of the YouTube embedded player allows us to avoid storing cookies and so to add tarteaucitron JS specific rules. More info about the Privacy Enhanced Mode.
Description
Change our youtube url since we don't want cookies from youtube.
Motivation & Context
Have the right cookie policy
Types of change
Live previews
Checklist
Contribution
Accessibility
Design
Development
Documentation
Checklist (for Core Team only)
After the merge