Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

YouTube: Change url to avoid cookies from YouTube. #2089

Merged
merged 18 commits into from
Jul 28, 2023

Conversation

louismaximepiton
Copy link
Member

@louismaximepiton louismaximepiton commented Jun 14, 2023

Description

Change our youtube url since we don't want cookies from youtube.

Motivation & Context

Have the right cookie policy

Types of change

  • New feature (non-breaking change which adds functionality)

Live previews

Checklist

Contribution

Accessibility

  • My change follows accessibility good practices; I have at least run axe

Design

  • My change respects the design guidelines defined in Orange Design System
  • My change is compatible with responsive display

Development

  • My change follows the developer guide
  • (NA) I have added JavaScript unit tests to cover my changes
  • (NA) I have added SCSS unit tests to cover my changes

Documentation

  • (NA) My change introduces changes to the documentation and/or I have updated the documentation accordingly

Checklist (for Core Team only)

  • (NA) My change introduces changes to the migration guide
  • (NA) My new component is added in Storybook
  • (NA) My new component is compatible with RTL
  • Manually run BrowserStack tests
  • Manually test browser compatibility with BrowserStack (Chrome >= 60, Firefox >= 60 (+ ESR), Edge, Safari >= 12, iOS Safari, Chrome & Firefox on Android)
  • Code review
  • Design review
  • A11y review

After the merge

@louismaximepiton louismaximepiton added v5 dependencies Pull requests that update a dependency file security labels Jun 14, 2023
@netlify
Copy link

netlify bot commented Jun 14, 2023

Deploy Preview for boosted ready!

Name Link
🔨 Latest commit 96e57d2
🔍 Latest deploy log https://app.netlify.com/sites/boosted/deploys/64c373613950df0007477713
😎 Deploy Preview https://deploy-preview-2089--boosted.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@louismaximepiton louismaximepiton marked this pull request as ready for review June 15, 2023 09:37
@julien-deramond julien-deramond removed security dependencies Pull requests that update a dependency file labels Jun 19, 2023
Copy link
Contributor

@MewenLeHo MewenLeHo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if it's working correctly, could you please check so I can finish this review?

@sonarcloud
Copy link

sonarcloud bot commented Jun 21, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@louismaximepiton louismaximepiton changed the title Tarteaucitron: Add youtube cookies to our management panel YouTube: Change url to avoid cookies from YouTube. Jul 24, 2023
Copy link
Contributor

@MewenLeHo MewenLeHo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI when I open your preview with Chrome (private navigation) I now have this warning:

cookies-error

I don't have it in other previews, so it's probably related to the recent changes made to this pull request.

@louismaximepiton
Copy link
Member Author

As discussed together, it seems that the issue comes from the cookie settings of the browser (if I accept them all I don't have the issue anymore). This looks like a netlify issue.

@MewenLeHo
Copy link
Contributor

As discussed together, it seems that the issue comes from the cookie settings of the browser (if I accept them all I don't have the issue anymore). This looks like a netlify issue.

I would add that we found this problem using Chrome in private mode. It seems to works fine with other browsers, even in private navigation.

@julien-deramond julien-deramond added the docs Improvements or additions to documentation label Jul 28, 2023
Copy link
Member

@julien-deramond julien-deramond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. No more cookies on Chrome with normal navigation. The video is still displayed correctly.

Turning on the Privacy Enhanced Mode of the YouTube embedded player allows us to avoid storing cookies and so to add tarteaucitron JS specific rules. More info about the Privacy Enhanced Mode.

julien-deramond

This comment was marked as duplicate.

@julien-deramond julien-deramond merged commit 18a5ee4 into main Jul 28, 2023
12 checks passed
@julien-deramond julien-deramond deleted the main-lmp-add-youtube-cookies branch July 28, 2023 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to documentation v5
Projects
Development

Successfully merging this pull request may close these issues.

3 participants