Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: fix search box alignment in navbar #2078

Merged
merged 4 commits into from
Jun 12, 2023

Conversation

hannahiss
Copy link
Member

@hannahiss hannahiss commented Jun 9, 2023

Note: Please transform - [ ] into - (NA) in the description when things are not applicable

Related issues

Description

  • Change .nav-item class to .navbar-item
  • Move todo outside of visible code example

Motivation & Context

Changes needed:

  • to have the right alignment of search box in navbar (it was ok in the example, but not ok in displayed code)
  • not to have a visible todo

Types of change

  • Bug fix (non-breaking which fixes an issue)

Live previews

Checklist

Contribution

Accessibility

  • My change follows accessibility good practices; I have at least run axe

Design

  • My change respects the design guidelines defined in Orange Design System
  • My change is compatible with responsive display

Development

  • My change follows the developer guide
  • (NA) I have added JavaScript unit tests to cover my changes
  • (NA) I have added SCSS unit tests to cover my changes

Documentation

  • My change introduces changes to the documentation and/or I have updated the documentation accordingly

Checklist (for Core Team only)

  • My change introduces changes to the migration guide
  • (NA) My new component is added in Storybook
  • (NA) My new component is compatible with RTL
  • (NA) Manually run BrowserStack tests
  • (NA) Manually test browser compatibility with BrowserStack (Chrome >= 60, Firefox >= 60 (+ ESR), Edge, Safari >= 12, iOS Safari, Chrome & Firefox on Android)
  • Code review
  • Design review
  • A11y review

After the merge

@netlify
Copy link

netlify bot commented Jun 9, 2023

Deploy Preview for boosted ready!

Name Link
🔨 Latest commit ba99574
🔍 Latest deploy log https://app.netlify.com/sites/boosted/deploys/6486c78d9751f900086e25db
😎 Deploy Preview https://deploy-preview-2078--boosted.netlify.app/docs/5.3/components/orange-navbar
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@hannahiss hannahiss marked this pull request as ready for review June 9, 2023 14:07
@hannahiss hannahiss self-assigned this Jun 9, 2023
Copy link
Member

@julien-deramond julien-deramond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dropped entirely the useless TODO via 254442c.

There's probably a missing .col-3 class as well (suggestion in the code).

site/content/docs/5.3/components/orange-navbar.md Outdated Show resolved Hide resolved
@julien-deramond julien-deramond added v5 docs Improvements or additions to documentation labels Jun 12, 2023
add col-3

Co-authored-by: Julien Déramond <julien.deramond@orange.com>
@sonarcloud
Copy link

sonarcloud bot commented Jun 12, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@julien-deramond julien-deramond self-requested a review June 12, 2023 07:29
@julien-deramond julien-deramond merged commit ba3cc7b into main Jun 12, 2023
@julien-deramond julien-deramond deleted the main-his-fix-navbar-search branch June 12, 2023 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to documentation v5
Projects
Development

Successfully merging this pull request may close these issues.

2 participants