-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(range): provide an example to display the value #1714
Conversation
✅ Deploy Preview for boosted ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
712e674
to
7b1cfcf
Compare
Kudos, SonarCloud Quality Gate passed! |
after some checkings, i think that we should use an output tag, as follow:
it's seems to work well with screen readers |
It confirms what we talked about with @louismaximepiton in private. Thanks for the feedback @Aniort. I'll make some changes to go with it! |
8e1691e
to
3de0c1e
Compare
@Aniort, this PR's ready for final a11y review based on #1714 (comment). Should be quick to double-check 😄 |
to avoid a double vocalization with both screen readers Jaws & NVDA please add ariahidden to output tag: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One thing and we're good
Co-authored-by: Louis-Maxime Piton <louismaxime.piton@orange.com>
Kudos, SonarCloud Quality Gate passed! |
Description
This PR provides a new example in the input range documentation to show how to display the value as a label for better usability.
Regarding a11y, here is how I defined the HTML structure and attributes:
Avoided a double<label>
and chose a<span>
aria-hidden="true"
it to avoid a double announce for the same value.Types of change
Live previews
Checklist
npm run lint
)