Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Script: Removing an issue on certain windows config running docs-accessibility. #1665

Merged
merged 1 commit into from
Nov 29, 2022

Conversation

louismaximepiton
Copy link
Member

@louismaximepiton louismaximepiton commented Nov 28, 2022

Related issues

NA

Description

Adding a parameter to make it work on windows with certain config:

Running Pa11y on 123 URLs:

> http://localhost:9001/docs/5.2/about/overview/ - Failed to run
> http://localhost:9001/docs/5.2/getting-started/accessibility/ - Failed to run
> http://localhost:9001/docs/5.2/components/accordion/ - Failed to run
> http://localhost:9001/docs/5.2/components/alerts/ - Failed to run
> http://localhost:9001/docs/5.2/extend/approach/ - Failed to run
> http://localhost:9001/docs/5.2/components/back-to-top/ - Failed to run
> http://localhost:9001/docs/5.2/utilities/background/ - Failed to run
> http://localhost:9001/docs/5.2/components/badge/ - Failed to run

Motivation & Context

Running Puppeteer can be tough on certain windows config. Here the Puppeteer config for docs-accessibility should not break anything anywhere else.

Types of change

  • Refactoring (non-breaking change)

Live previews

Check that the npm run docs-accessibility isn't break on local.
Check that the ci looks fine with this config. ✔️

Checklist

  • I have read the contributing guidelines
  • My code follows the code style of the project (using npm run lint)
  • My change introduces changes to the documentation
  • My change introduces changes to the migration guide
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed

Development

  • Run linters
  • Run compilers

Reviews

  • Code review

@sonarcloud
Copy link

sonarcloud bot commented Nov 28, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@netlify
Copy link

netlify bot commented Nov 28, 2022

Deploy Preview for boosted ready!

Name Link
🔨 Latest commit 9d11bc7
🔍 Latest deploy log https://app.netlify.com/sites/boosted/deploys/6384d500c5a1f600091b0d5e
😎 Deploy Preview https://deploy-preview-1665--boosted.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Member

@julien-deramond julien-deramond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't seem to cause any issue on macOS so if it is better for Windows (specific config) users LGTM!

@julien-deramond julien-deramond merged commit 43c1382 into main Nov 29, 2022
@julien-deramond julien-deramond deleted the main-lmp-add-puppeteer-config branch November 29, 2022 05:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants