Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix missing attribute in global header standard example #1662

Merged
merged 3 commits into from
Nov 28, 2022
Merged

Fix missing attribute in global header standard example #1662

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c53ce8e
Fix missing attribute
MewenLeHo Nov 28, 2022
f053a5f
Fix more missing attributes
MewenLeHo Nov 28, 2022
4f12491
Merge branch 'main' into main-mlh-fix-missing-attribute-in-header-exa…
julien-deramond Nov 28, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions site/content/docs/5.2/components/orange-navbar.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,7 +127,7 @@ An additional navbar (with text or icon items) can be added on the right of the

<!-- Right navbar of the Supra bar -->
<ul class="navbar-nav border-top border-1 border-dark d-flex flex-row d-lg-none">
<li class="nav-item"><a class="nav-link active" href="#" aria-label="EN English version">EN</a></li>
<li class="nav-item"><a class="nav-link active" href="#" aria-label="EN English version" aria-current="true">EN</a></li>
<li class="nav-item"><a class="nav-link" href="#" aria-label="FR Version française" lang="fr" hreflang="fr">FR</a></li>
<li class="nav-item"><a class="nav-link" href="#" aria-label="ES Versión en español" lang="es" hreflang="es">ES</a></li>
</ul>
Expand Down Expand Up @@ -171,7 +171,7 @@ An additional navbar (with text or icon items) can be added on the right of the
<!-- Navbar with links -->
<div id="global-header-1.1" class="navbar-collapse collapse me-lg-auto global-header-1">
<ul class="navbar-nav">
<li class="nav-item"><a class="nav-link active" href="#">Discover</a></li>
<li class="nav-item"><a class="nav-link active" href="#" aria-current="page">Discover</a></li>
<li class="nav-item"><a class="nav-link" href="#">Shop</a></li>
</ul>
</div>
Expand Down Expand Up @@ -432,7 +432,7 @@ It should be visible only for the larger screens (`lg` to `xxl` breakpoints) usi
<div class="container-xxl">
<div id="global-header-6.1" class="navbar-collapse collapse m-0 global-header-6">
<ul class="navbar-nav">
<li class="nav-item"><a class="nav-link active" href="#">Label</a></li>
<li class="nav-item"><a class="nav-link active" href="#" aria-current="page">Label</a></li>
<li class="nav-item"><a class="nav-link" href="#">Label</a></li>
<li class="nav-item"><a class="nav-link" href="#">Label</a></li>
<li class="nav-item"><a class="nav-link" href="#">Label</a></li>
Expand Down