-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix languages buttons accessible names #1629
Fix languages buttons accessible names #1629
Conversation
✅ Deploy Preview for boosted ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Haven't reviewed the PR but I'm wondering whether we should mention it into the migration guide or not. I'd say yes but not 100% sure neither :) |
Same here, I was waiting for your opinion ;) |
Tried something in 44298a7. Let me know what you think. |
Looks good. I am just wondering if we should add why it could be useful (because for accessibility purposes, the visible name must be included in the accessible name)? I don't know if the migration guide is the right place to explain that? |
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
Description
Simple accessibility fix.
Motivation & Context
The name of the buttons must be included in their accessible names.
See Success Criterion 2.5.3 Label in Name for more details.
Types of change
Live previews
Checklist
npm run lint
)