Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix languages buttons accessible names #1629

Merged
merged 5 commits into from
Nov 16, 2022

Conversation

MewenLeHo
Copy link
Contributor

@MewenLeHo MewenLeHo commented Nov 15, 2022

Description

Simple accessibility fix.

Motivation & Context

The name of the buttons must be included in their accessible names.
See Success Criterion 2.5.3 Label in Name for more details.

Types of change

  • Bug fix (non-breaking which fixes an issues)

Live previews

Checklist

  • I have read the contributing guidelines
  • My code follows the code style of the project (using npm run lint)
  • My change introduces changes to the documentation
  • My change introduces changes to the migration guide
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed

@MewenLeHo MewenLeHo self-assigned this Nov 15, 2022
@netlify
Copy link

netlify bot commented Nov 15, 2022

Deploy Preview for boosted ready!

Name Link
🔨 Latest commit abebc40
🔍 Latest deploy log https://app.netlify.com/sites/boosted/deploys/63749ff9a655fa000948475f
😎 Deploy Preview https://deploy-preview-1629--boosted.netlify.app/docs/5.2/migration
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@julien-deramond
Copy link
Member

Haven't reviewed the PR but I'm wondering whether we should mention it into the migration guide or not. I'd say yes but not 100% sure neither :)

@MewenLeHo
Copy link
Contributor Author

Haven't reviewed the PR but I'm wondering whether we should mention it into the migration guide or not. I'd say yes but not 100% sure neither :)

Same here, I was waiting for your opinion ;)

@julien-deramond
Copy link
Member

Tried something in 44298a7. Let me know what you think.

@MewenLeHo
Copy link
Contributor Author

Tried something in 44298a7. Let me know what you think.

Looks good. I am just wondering if we should add why it could be useful (because for accessibility purposes, the visible name must be included in the accessible name)? I don't know if the migration guide is the right place to explain that?

@sonarcloud
Copy link

sonarcloud bot commented Nov 16, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@julien-deramond julien-deramond merged commit 945d22f into main Nov 16, 2022
@julien-deramond julien-deramond deleted the main-mlh-accessible-names-of-languages-buttons branch November 16, 2022 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants