Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix vertical alignment of dropdown in navbar #1625

Merged
merged 4 commits into from
Nov 15, 2022

Conversation

MewenLeHo
Copy link
Contributor

@MewenLeHo MewenLeHo commented Nov 15, 2022

Related issues

Closes #1607

Description

Fix vertical alignment.

Motivation & Context

Fix vertical alignment.

Types of change

  • Bug fix (non-breaking which fixes an issues)

Live previews

https://deploy-preview-1625--boosted.netlify.app/docs/5.2/components/dropdowns/#dark-dropdowns

Checklist

  • I have read the contributing guidelines
  • My code follows the code style of the project (using npm run lint)
  • My change introduces changes to the documentation
  • My change introduces changes to the migration guide
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed

@MewenLeHo MewenLeHo added v5 docs Improvements or additions to documentation labels Nov 15, 2022
@MewenLeHo MewenLeHo self-assigned this Nov 15, 2022
@netlify
Copy link

netlify bot commented Nov 15, 2022

Deploy Preview for boosted ready!

Name Link
🔨 Latest commit 9de3e09
🔍 Latest deploy log https://app.netlify.com/sites/boosted/deploys/6373a736b6291000084e6bde
😎 Deploy Preview https://deploy-preview-1625--boosted.netlify.app/docs/5.2/components/dropdowns
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@julien-deramond

This comment was marked as resolved.

@MewenLeHo
Copy link
Contributor Author

Since it's a navbar example I kept the fix with the logo:
screenshot-deploy-preview-1625--boosted netlify app-2022 11 15-11_52_43

Do you prefer the fix without the logo?
screenshot-deploy-preview-1625--boosted netlify app-2022 11 15-11_53_10

@sonarcloud
Copy link

sonarcloud bot commented Nov 15, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Member

@julien-deramond julien-deramond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I'll create 2 separate PRs based on my comments.

@julien-deramond julien-deramond merged commit 86dfb2c into main Nov 15, 2022
@julien-deramond julien-deramond deleted the main-mlh-vertical-alignment-navbar-dropdown branch November 15, 2022 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to documentation v5
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dark dropdown in navbar is not correctly vertically aligned
2 participants