-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix vertical alignment of dropdown in navbar #1625
Merged
julien-deramond
merged 4 commits into
main
from
main-mlh-vertical-alignment-navbar-dropdown
Nov 15, 2022
Merged
Fix vertical alignment of dropdown in navbar #1625
julien-deramond
merged 4 commits into
main
from
main-mlh-vertical-alignment-navbar-dropdown
Nov 15, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for boosted ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
This comment was marked as resolved.
This comment was marked as resolved.
julien-deramond
requested changes
Nov 15, 2022
Kudos, SonarCloud Quality Gate passed! |
julien-deramond
approved these changes
Nov 15, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I'll create 2 separate PRs based on my comments.
julien-deramond
deleted the
main-mlh-vertical-alignment-navbar-dropdown
branch
November 15, 2022 15:17
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issues
Closes #1607
Description
Fix vertical alignment.
Motivation & Context
Fix vertical alignment.
Types of change
Live previews
https://deploy-preview-1625--boosted.netlify.app/docs/5.2/components/dropdowns/#dark-dropdowns
Checklist
npm run lint
)