Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Customize/colors : Move Orange's colors paragraph and add warning #1610

Merged
merged 5 commits into from
Nov 14, 2022

Conversation

hannahiss
Copy link
Member

@hannahiss hannahiss commented Nov 10, 2022

Related issues

Closes #1356

Description

  • Put the paragraph "Orange's colors" at the very beginning of the page, as the 1st paragraph of the page
  • In the paragraph "All colors", put the text "All Boosted colors are available as Sass variables and a Sass map..." in an ODS warning message.

Motivation & Context

This issue comes from the work done in Issue #1201

Types of change

Update doc only

Live previews

Checklist

  • I have read the contributing guidelines
  • My code follows the code style of the project (using npm run lint)
  • My change introduces changes to the documentation
  • My change introduces changes to the migration guide
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed

@netlify
Copy link

netlify bot commented Nov 10, 2022

Deploy Preview for boosted ready!

Name Link
🔨 Latest commit 56da219
🔍 Latest deploy log https://app.netlify.com/sites/boosted/deploys/6371f9fe4b113a0008d525c8
😎 Deploy Preview https://deploy-preview-1610--boosted.netlify.app/docs/5.2/customize/color
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@hannahiss
Copy link
Member Author

It is to be noted that the sub-section"Notes on Sass" that is in Bootstrap under "All colors" paragraph, is under "Orange's colors" in this version (I didn't change it but I mention it to be sure it is wanted).

Copy link
Member

@louismaximepiton louismaximepiton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should the a11y team to have their point of view.

site/content/docs/5.2/customize/color.md Outdated Show resolved Hide resolved
@julien-deramond julien-deramond added v5 docs Improvements or additions to documentation fix labels Nov 14, 2022
Copy link
Member

@julien-deramond julien-deramond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made some changes to reflect the comments in 784bcca and 56da219

@sonarcloud
Copy link

sonarcloud bot commented Nov 14, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@julien-deramond julien-deramond merged commit 1b40104 into main Nov 14, 2022
@julien-deramond julien-deramond deleted the main-his-docs-colors branch November 14, 2022 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to documentation fix v5
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docs > Customize > Color : Change information order in the page + add explanations
3 participants