Add aria hidden true to svgs in tooltips #1555
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for boosted ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
|
Kudos, SonarCloud Quality Gate passed!
|
julien-deramond
approved these changes
Oct 17, 2022
There was a problem hiding this comment.
LGTM! You can create a PR for Bootstrap in the same spirit to fix the SVG example in https://getbootstrap.com/docs/5.2/components/tooltips/#directions.
julien-deramond
deleted the
main-mlh-add-aria-hidden-to-svgs-in-tooltips
branch
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issues
Closes #1554
Description
SVGs in tooltips do not carry any specific information so they should not be readable by screen reader so we should add 'aria-hidden=true'
In addition, replace the missing 'focusable=false' on the first svg (seen with @Aniort)
Motivation & Context
Accessibility improvement for tooltips.
Types of change
Live previews
Checklist
npm run lint)