Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

List-group: Add dark variant #1525

Merged
merged 2 commits into from
Sep 13, 2022
Merged

Conversation

louismaximepiton
Copy link
Member

First round of dark variant for list-group.

@netlify
Copy link

netlify bot commented Sep 8, 2022

Deploy Preview for boosted ready!

Name Link
🔨 Latest commit 3ebc139
🔍 Latest deploy log https://app.netlify.com/sites/boosted/deploys/631b2011a8a2260008297848
😎 Deploy Preview https://deploy-preview-1525--boosted.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@julien-deramond
Copy link
Member

julien-deramond commented Sep 9, 2022

The disabled state is a bit difficult to read because not in bold. I suppose this will be tackled with the "re-branding" of the list groups in another PR (maybe #1467)?

Screenshot from 2022-09-09 09-56-59

@louismaximepiton
Copy link
Member Author

Yes exactly, every link will be in bold with the incoming re branding. I think it doesn't causes any a11y issue since these are disabled items.

Copy link
Member

@julien-deramond julien-deramond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

@julien-deramond julien-deramond merged commit 19bcc40 into main Sep 13, 2022
@julien-deramond julien-deramond deleted the main-lmp-list-group-dark-first branch September 13, 2022 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants