-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mark: make .mark
branded
#1506
Mark: make .mark
branded
#1506
Conversation
✅ Deploy Preview for boosted ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
In the Algolia's search modal, the highlighted result text in in bold. Don't we need to do the same here? It seems to be difficult to read the white text on black background. |
Not sure that we should force it but might be better for accessibility, so I'll implement it asap! |
Confirmation from design and a11y, bold text is not necessary so I'll update the PR to use regulard text for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 🚀
Fixes #1504.