Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark: make .mark branded #1506

Merged
merged 8 commits into from
Sep 13, 2022
Merged

Mark: make .mark branded #1506

merged 8 commits into from
Sep 13, 2022

Conversation

louismaximepiton
Copy link
Member

Fixes #1504.

@netlify
Copy link

netlify bot commented Aug 31, 2022

Deploy Preview for boosted ready!

Name Link
🔨 Latest commit c2d0f4c
🔍 Latest deploy log https://app.netlify.com/sites/boosted/deploys/63208a533c07d20008f045bb
😎 Deploy Preview https://deploy-preview-1506--boosted.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@julien-deramond
Copy link
Member

julien-deramond commented Sep 6, 2022

In the Algolia's search modal, the highlighted result text in in bold. Don't we need to do the same here? It seems to be difficult to read the white text on black background.

@louismaximepiton
Copy link
Member Author

In the Algolia's search modal, the highlighted result text in in bold. Don't we need to do the same here? It seems to be difficult to read the white text on black background.

Not sure that we should force it but might be better for accessibility, so I'll implement it asap!

@julien-deramond
Copy link
Member

Confirmation from design and a11y, bold text is not necessary so I'll update the PR to use regulard text for <mark> and check if an update is needed for the Algolia search results.

Copy link
Member

@julien-deramond julien-deramond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

@julien-deramond julien-deramond merged commit a1d25dc into main Sep 13, 2022
@julien-deramond julien-deramond deleted the main-lmp-mark-branded branch September 13, 2022 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mark: Brand mark
2 participants