fix(docs): move 'Dark variant' sections out of 'Example' for alerts and accordions #1502
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for boosted ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
louismaximepiton
approved these changes
Aug 30, 2022
There was a problem hiding this comment.
Maybe change dark offcanvas on Bs side to be more consistent!
LGTM on our side.
julien-deramond
deleted the
main-jd-move-accordion-dark-variant-section
branch
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For consistency with Bootstrap docs architecture, I propose to move 'Dark variant' section out of the 'Example' section for alerts and accordions.
In Bootstrap:
🙏 Please double-check if I haven't forgotten components in Boosted.