Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix .mark padding (backport from v4.6) #1484

Merged
merged 3 commits into from
Aug 26, 2022
Merged

Conversation

isabellechanclou
Copy link
Member

@isabellechanclou isabellechanclou commented Aug 25, 2022

Backport form v4.6: Fix of <mark> vertical padding to avoid overlapping on the lines above and below. See #1465.

ℹ️ <mark> is no more used in Docs>About>Brand>#master-artwork, but only in Docs/content/typography/#inline-text-elements and in Example/cheatsheet not visible at the moment. In these pages, depending on the usage of the context, the change might not show.

Signed-off-by: Isabelle Chanclou <isabelle.chanclou@orange.com>
@isabellechanclou isabellechanclou self-assigned this Aug 25, 2022
@netlify
Copy link

netlify bot commented Aug 25, 2022

Deploy Preview for boosted ready!

Name Link
🔨 Latest commit 6060c19
🔍 Latest deploy log https://app.netlify.com/sites/boosted/deploys/6308bb1e746ea00008572ab4
😎 Deploy Preview https://deploy-preview-1484--boosted.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Member

@louismaximepiton louismaximepiton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't we keep the Bootstrap value to be closer to Bs version ?

scss/_variables.scss Outdated Show resolved Hide resolved
julien-deramond and others added 2 commits August 26, 2022 14:14
Co-authored-by: Louis-Maxime Piton <louismaxime.piton@orange.com>
@julien-deramond julien-deramond merged commit 32497f3 into main Aug 26, 2022
@julien-deramond julien-deramond deleted the main-ic-fix-mark-padding branch August 26, 2022 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants