Breadcrumb: Add dark variant #1430
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for boosted ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
54 tasks
|
LGTM |
isabellechanclou
approved these changes
Aug 12, 2022
julien-deramond
requested changes
Aug 24, 2022
louismaximepiton
force-pushed
the
main-lmp-breadcrumb-dark-variant
branch
from
31da0bb
to
3607861
Compare
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure if this is the best solution but this is likely the smallest one since we define the color to inherit (cascading from
*-darkrule) and background-color to transparent + active state of links are linked to--#{$prefix}link-hover-color.Related to #891.
Checks
Please check that dark breadcrumbs are fine.