Remove hover for active tab #1420
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for boosted ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
MewenLeHo
force-pushed
the
main-mlh-navs-tabs-fix-hiver-color-selected-items
branch
from
bdb7dd9
to
2ade90c
Compare
isabellechanclou
approved these changes
Jul 29, 2022
This comment was marked as outdated.
This comment was marked as outdated.
scss/_nav.scss
Outdated
| &.active:hover { | ||
| color: var(--#{$prefix}nav-tabs-link-active-color); | ||
| } | ||
|
|
There was a problem hiding this comment.
OK with this.
the text color turns orange when it shouldn't. It has to do with the focus management.
|
Regression: Active + focused tab item changes color (+ border color) when hovered.
We don't see the cursor but I'm hovering the tab item in this Gif |
This comment was marked as resolved.
This comment was marked as resolved.
|
Kudos, SonarCloud Quality Gate passed!
|
julien-deramond
deleted the
main-mlh-navs-tabs-fix-hiver-color-selected-items
branch
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1332