Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Webpack, Vite and Parcel guides enhancements #1384

Merged
merged 11 commits into from
Dec 28, 2022
Merged

Webpack, Vite and Parcel guides enhancements #1384

merged 11 commits into from
Dec 28, 2022

Conversation

julien-deramond
Copy link
Member

@julien-deramond julien-deramond commented Jul 18, 2022 •
edited
Loading

Following up #1354, isolated this development in order to be reviewable by the team.

For Webpack, Parcel and Vite guides:

  • Improve the doc to include focus-visible It's already included by default in our JS file
  • Improve the doc to include how to embed Helvetica fonts
    • Parcel
    • Vite
    • Webpack
  • Modify the 2 rendered images per guide (⚠️ Applied https://kraken.io/web-interface but the images are still heavier than the original 🤷)
    • Parcel default
    • Parcel configured
    • Vite default
    • Vite configured
    • Webpack default
    • Webpack configured
  • Add a specific message for Boosted users regarding the info callout at the beginning to explain that they can use the Bootstrap shared projects but they need to tweak them a bit for them to work with Boosted

JavaScript page:

  • Modify /docs/5.2/getting-started/javascript/#using-boosted-as-a-module to show that concerns Bootstrap and not Boosted but that would need just some tweaks to make it work

Live previews

@julien-deramond julien-deramond marked this pull request as draft July 18, 2022 11:40
@julien-deramond julien-deramond added v5 docs Improvements or additions to documentation labels Jul 18, 2022
@netlify
Copy link

netlify bot commented Jul 18, 2022 •
edited
Loading

✅ Deploy Preview for boosted ready!

Name Link
🔨 Latest commit db1ee4f
🔍 Latest deploy log https://app.netlify.com/sites/boosted/deploys/63ac1d2a5c0bc200082f1779
😎 Deploy Preview https://deploy-preview-1384--boosted.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@louismaximepiton louismaximepiton force-pushed the main-jd-webpack-parcel-vite-guides-enhancement branch from d6c86ff to 841cb31 Compare August 31, 2022 13:12
@louismaximepiton louismaximepiton linked an issue Nov 9, 2022 that may be closed by this pull request
Documentation > Change 'Boostrap and Vite!' image for 'Boosted and Vite!' image #1608
Closed
2 tasks
@louismaximepiton
Copy link
Member

Since there are only images missing in here (and review as well), could @julien-deramond or @isabellechanclou do the pictures on Safari ?

@julien-deramond
Copy link
Member Author

The PR isn't finished at all. I need to include focus-visible, fonts and so on. The screenshots/images will be done at the end of the PR.

@julien-deramond julien-deramond marked this pull request as ready for review December 28, 2022 08:05
@sonarcloud
Copy link

sonarcloud bot commented Dec 28, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

louismaximepiton
louismaximepiton approved these changes Dec 28, 2022
View reviewed changes
Copy link
Member

@louismaximepiton louismaximepiton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@julien-deramond julien-deramond merged commit 3352d21 into main Dec 28, 2022
@julien-deramond julien-deramond deleted the main-jd-webpack-parcel-vite-guides-enhancement branch December 28, 2022 10:58
@julien-deramond julien-deramond mentioned this pull request Dec 28, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@louismaximepiton louismaximepiton louismaximepiton approved these changes

Assignees
No one assigned
Labels
docs Improvements or additions to documentation v5
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Documentation > Change 'Boostrap and Vite!' image for 'Boosted and Vite!' image
2 participants
@julien-deramond @louismaximepiton