fix(table): row selection: space after checkbox incorrect

[hannahiss]

Add a negative right margin to adjust space in that case

Closes #1236

[netlify]

✅ Deploy Preview for boosted ready!

Name	Link
🔨 Latest commit	c5f0af3
🔍 Latest deploy log	https://app.netlify.com/sites/boosted/deploys/637dc483c27dc00009c856e9
😎 Deploy Preview	https://deploy-preview-1272--boosted.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site settings.

[louismaximepiton]

Out of context but, did you try changing the html structure ? (without the div.form-check for example)

[louismaximepiton]

LGTM 🚀

[julien-deramond]

There's no way here to have 40px x 40px? It seems to be like that in the DSM.

[julien-deramond]

With margin-right: -1.024rem we have a <td> width of:

• Ubuntu / Firefox: 40px
• Ubuntu / Chrome: 40.02px
  What about Windows? If we have the same values (really close to 40px) we could go for this -1.024rem 🤷

[louismaximepiton]

After digging a bit more inside tables, it appears that the columns take as much place as they can. This is why we have such weird sizes (you can try resize your window and you won't have the same size). Here is a workaround to have exactly 40px at each breakpoint (on first column):

<table class="table table-sm table-hover table-responsive">

  <colgroup>
    <col style="2.5rem">
  </colgroup>

  <thead>
  </thead>
  <tbody>
  </tbody>
</table>

Here the 2.5rem is arbitrary, I didn't check if another value could be better here

[hannahiss]

Louis-Maxime's solution seems good and well supported by all browsers, so I added colgroup to fix first column width.
Concerning the negative right margin, it is still needed to prevent second column to move to the right, but 1rem seems ok and cleaner that 1,0625rem or -1.024rem.

[hannahiss]

@julien-deramond I'm going to update migration guide too ;-)

[julien-deramond]

LGTM. Just a suggestion to improve the migration guide note.

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication