You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I think the js should be improved ? Maybe on Bs side
Focus on carousel doesn't seem to pause it Focus on indicators is weird : the current page indicator is kinda scaled up
Should the carousel pauses on focus? Maybe. It may be useful for keyboard users.
What do you think about it @julien-deramond? It's a question for @Aniort and our accessibility experts.
However it's not the subject of this pull request.
Should the carousel pauses on focus? Maybe. It may be useful for keyboard users. What do you think about it @julien-deramond? It's a question for @Aniort and our accessibility experts. However it's not the subject of this pull request.
Not sure it should since you're focusing the arrow, not the carousel itself (the content). But I let @Aniort gives us his feedback.
Agree that's not something to take into account in this PR. As said by @louismaximepiton if we change this behavior let's propose it directly to Bootstrap.
The reason will be displayed to describe this comment to others. Learn more.
The focus looks good to me 🚀
As discussed together, we can't use the $outline-width here because many outline-offset use this variable also we don't wanna change it now. It might introduce some issues that we don't want to handle before 5.2.0
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1084