Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(docs): reorder alphabetically list of components #1188

Merged
merged 2 commits into from
Apr 6, 2022
Merged

chore(docs): reorder alphabetically list of components #1188

merged 2 commits into from
Apr 6, 2022

Conversation

julien-deramond
Copy link
Member

@julien-deramond julien-deramond commented Apr 5, 2022 •
edited
Loading

This PR is a proposal to reorder alphabetically the list of components in the documentation. IMHO it is simpler to find the components in the list and more natural.

After the merge

  • If we agree on that, I'll create a PR for Bootstrap as well
  • Check if it can be backported to v4

@julien-deramond julien-deramond added v5 docs Improvements or additions to documentation labels Apr 5, 2022
@louismaximepiton
Copy link
Member

Maybe the one in docs/5.1/getting-started/introduction.md > Quick start > JS > Components could be handled in this PR too ?

@julien-deramond
Copy link
Member Author

julien-deramond commented Apr 6, 2022 •
edited
Loading

Maybe the one in docs/5.1/getting-started/introduction.md > Quick start > JS > Components could be handled in this PR too ?

Yep ofc, I thought it was already good; haven't seen the last one 🙃 Thx!
Fixed via bba819d

louismaximepiton
louismaximepiton approved these changes Apr 6, 2022
View reviewed changes
Copy link
Member

@louismaximepiton louismaximepiton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good to me.

@julien-deramond julien-deramond mentioned this pull request Apr 6, 2022
Merged
@julien-deramond julien-deramond merged commit e4c2127 into main Apr 6, 2022
@julien-deramond julien-deramond deleted the main-jd-alphabetical-order-in-doc branch April 6, 2022 08:51
@julien-deramond julien-deramond mentioned this pull request Apr 6, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@louismaximepiton louismaximepiton louismaximepiton approved these changes

Assignees
No one assigned
Labels
backport-to-v4 docs Improvements or additions to documentation v5
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@julien-deramond @louismaximepiton