Chore merge-main@7f35bc5 #1167
Merged
Chore merge-main@7f35bc5 #1167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
julien-deramond
commented
Mar 28, 2022
•
julien-deramond
commented
- twbs/bootstrap@55fb59c
- twbs/bootstrap@298cb91
- twbs/bootstrap@21fa2cf
- twbs/bootstrap@e77ae50
- twbs/bootstrap@a814249
- twbs/bootstrap@b7cce49
- twbs/bootstrap@fcc2c80
- twbs/bootstrap@699402b
- twbs/bootstrap@dd93551
- twbs/bootstrap@d4e87d2
- twbs/bootstrap@7e5a801
- twbs/bootstrap@645f955
- twbs/bootstrap@3ef6a43: Nothing to do in Boosted
- twbs/bootstrap@28f150d
- twbs/bootstrap@88da704
- twbs/bootstrap@ec0e1c2
- twbs/bootstrap@3673933
- twbs/bootstrap@6e90434
- twbs/bootstrap@d21a51a
- twbs/bootstrap@5bdd5e0
- twbs/bootstrap@05c6e7d
- twbs/bootstrap@63145c8
- twbs/bootstrap@c73480c
- twbs/bootstrap@ea7ff1e
- twbs/bootstrap@e72a090
- twbs/bootstrap@58ac9a9
- twbs/bootstrap@ce655ee
⚠️ This one had edge cases in Boosted so check in details all those cases
- twbs/bootstrap@d16088d
- twbs/bootstrap@e567d51
- twbs/bootstrap@1936e0c
- twbs/bootstrap@7c966f5
- twbs/bootstrap@acf6ea7
- 💥 Breaking changes reverted in another commit after
- twbs/bootstrap@70cb00c
- twbs/bootstrap@8fe82c7
- twbs/bootstrap@a9a89de
- Let's do it in another PR but make the same modifications in Boosted for our custom content
- twbs/bootstrap@33827d2
- twbs/bootstrap@91f6a01
- twbs/bootstrap@11751c6
- twbs/bootstrap@8182fd9
- twbs/bootstrap@71582ea
- twbs/bootstrap@a4841af
- twbs/bootstrap@b165f35
- twbs/bootstrap@88bd287
- twbs/bootstrap@0e5cd69
- twbs/bootstrap@fbf6440
- twbs/bootstrap@9e73b6a
- twbs/bootstrap@0eb8080
- twbs/bootstrap@7f35bc5
julien-deramond
commented
Mar 29, 2022
| } | ||
|
|
||
| snippetButtonTooltip('.btn-clipboard', 'Copy to clipboard') | ||
| snippetButtonTooltip('.btn-edit', 'Edit on Stackblitz') |
There was a problem hiding this comment.
Should be StackBlitz.
See twbs/bootstrap#36073
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
julien-deramond
commented
Mar 29, 2022
| @@ -473,6 +473,7 @@ $utilities: map-merge( | |||
| lighter: $font-weight-lighter, | |||
| normal: $font-weight-normal, | |||
| bold: $font-weight-bold, | |||
| semibold: $font-weight-semibold, | |||
There was a problem hiding this comment.
Check in Bootstrap if fw-semibold wasn't defined for examples. Otherwise remove it in Boosted.
See twbs/bootstrap#36075
julien-deramond
commented
Mar 30, 2022
| - **Thicker table dividers are now opt-in.** We've removed the thicker and more difficult to override border between table groups and moved it to an optional class you can apply, `.table-group-divider`. [See the table docs for an example.]({{< docsref "/content/tables#table-group-dividers" >}}) | ||
| - Added `.form-check-reverse` modifier to flip the order of labels and associated checkboxes/radios. | ||
|
|
||
| - Added striped columns support to tables via |
There was a problem hiding this comment.
The end of the sentence seems to be missing.
See https://github.com/twbs/bootstrap/pull/36038/files#r839351166.
|
Tracked issues with StackBlitz in twbs/bootstrap#36088 and twbs/bootstrap#36091.
|
louismaximepiton
requested changes
Mar 31, 2022
| @@ -460,11 +462,11 @@ $body-text-align: null !default; | |||
| // | |||
| // Style anchor elements. | |||
|
|
|||
| $link-color: var(--#{$boosted-variable-prefix}link-color, $black) !default; // Boosted mod | |||
| $link-color: $black !default; // Boosted mod | |||
There was a problem hiding this comment.
All the variables that were using $link-color should be replaced by var(--#{$prefix}link-color) to have the same result.
There was a problem hiding this comment.
Changed it everywhere via 8f4315b. It fixes the .btn-link issue for the dark variant.
Need to check but IMO Bootstrap should probably do the same.
There was a problem hiding this comment.
| color: $black; | ||
| background-color: $primary; | ||
| border-color: $primary; | ||
| &.active { |
There was a problem hiding this comment.
Be careful here, :active to .active -> break the pressed state + maybe reset the previous states
There was a problem hiding this comment.
Tried to fix it via b465249.
How to test all the cases:
{{< example >}}
<nav aria-label="Page navigation example">
<ul class="pagination">
<li class="page-item">
<a class="page-link">Previous</a>
</li>
<li class="page-item">
<a class="page-link" href="#">1</a>
</li>
<li class="page-item" aria-current="page">
<a class="page-link" href="#">2</a>
</li>
<li class="page-item">
<a class="page-link" href="#">3</a>
</li>
<li class="page-item">
<a class="page-link" href="#">Next</a>
</li>
</ul>
<ul class="pagination">
<li class="page-item active">
<a class="page-link">Previous</a>
</li>
<li class="page-item active">
<a class="page-link" href="#">1</a>
</li>
<li class="page-item active" aria-current="page">
<a class="page-link" href="#">2</a>
</li>
<li class="page-item active">
<a class="page-link" href="#">3</a>
</li>
<li class="page-item active">
<a class="page-link" href="#">Next</a>
</li>
</ul>
<ul class="pagination">
<li class="page-item">
<a class="page-link active">Previous</a>
</li>
<li class="page-item">
<a class="page-link active" href="#">1</a>
</li>
<li class="page-item" aria-current="page">
<a class="page-link active" href="#">2</a>
</li>
<li class="page-item">
<a class="page-link active" href="#">3</a>
</li>
<li class="page-item">
<a class="page-link active" href="#">Next</a>
</li>
</ul>
<ul class="pagination">
<li class="page-item disabled">
<a class="page-link">Previous</a>
</li>
<li class="page-item disabled">
<a class="page-link" href="#">1</a>
</li>
<li class="page-item disabled" aria-current="page">
<a class="page-link" href="#">2</a>
</li>
<li class="page-item disabled">
<a class="page-link" href="#">3</a>
</li>
<li class="page-item disabled">
<a class="page-link" href="#">Next</a>
</li>
</ul>
<ul class="pagination">
<li class="page-item">
<a class="page-link disabled">Previous</a>
</li>
<li class="page-item">
<a class="page-link disabled" href="#">1</a>
</li>
<li class="page-item" aria-current="page">
<a class="page-link disabled" href="#">2</a>
</li>
<li class="page-item">
<a class="page-link disabled" href="#">3</a>
</li>
<li class="page-item">
<a class="page-link disabled" href="#">Next</a>
</li>
</ul>
</nav>
{{< /example >}}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.