Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(forms): change the margin left value between the required symbol and the label #1145

Closed

Conversation

julien-deramond
Copy link
Member

@julien-deramond julien-deramond commented Mar 9, 2022

Backport of the fix explained in #1144. ⚠️ Wait for its review before merging this one.

This PR doesn't need a design review since it would have already been done in the other PR. Just check that this code does the same thing than in the other PR and covers all the rendering cases.

Copy link
Member

@louismaximepiton louismaximepiton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe need a change in _o-forms.scss ? (l.85)

@julien-deramond julien-deramond deleted the v4-dev-jd-label-required-margin-left-value branch July 17, 2024 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants