Finish formatting JS file + clean up Sass variables modifications

Orange-OpenSource · Feb 24, 2022 · bbe452a · bbe452a
1 parent 1dca654
commit bbe452a
Show file tree

Hide file tree

Showing 2 changed files with 26 additions and 28 deletions.
diff --git a/js/src/quantity-selector.js b/js/src/quantity-selector.js
@@ -38,6 +38,25 @@ class QuantitySelector extends BaseComponent {
     return NAME
   }
 
+  // Public
+  ValueOnLoad(element) {
+    const counterInput = element.querySelector(SELECTOR_COUNTER_INPUT)
+    const btnUp = element.querySelector(SELECTOR_STEP_UP_BUTTON)
+    const btnDown = element.querySelector(SELECTOR_STEP_DOWN_BUTTON)
+
+    const min = counterInput.getAttribute('min')
+    const max = counterInput.getAttribute('max')
+    const step = Number(counterInput.getAttribute('step'))
+
+    if (Number(counterInput.value) - step < min) {
+      btnDown.setAttribute('disabled', '')
+    }
+
+    if (Number(counterInput.value) + step > max) {
+      btnUp.setAttribute('disabled', '')
+    }
+  }
+
   // Static
   static StepUp(event) {
     event.preventDefault()
@@ -65,25 +84,6 @@ class QuantitySelector extends BaseComponent {
     }
   }
 
-  // Public
-  ValueOnLoad(element) {
-    const counterInput = element.querySelector(SELECTOR_COUNTER_INPUT)
-    const BTN_UP = element.querySelector(SELECTOR_STEP_UP_BUTTON)
-    const BTN_DOWN = element.querySelector(SELECTOR_STEP_DOWN_BUTTON)
-
-    const MIN = counterInput.getAttribute('min')
-    const MAX = counterInput.getAttribute('max')
-    const STEP = Number(counterInput.getAttribute('step'))
-
-    if (Number(counterInput.value) - STEP < MIN) {
-      BTN_DOWN.setAttribute('disabled', '')
-    }
-
-    if (Number(counterInput.value) + STEP > MAX) {
-      BTN_UP.setAttribute('disabled', '')
-    }
-  }
-
   static StepDown(event) {
     event.preventDefault()
     const parent = event.target.closest(SELECTOR_INPUT_GROUP)
@@ -119,16 +119,16 @@ class QuantitySelector extends BaseComponent {
 
     const min = counterInput.getAttribute('min')
     const max = counterInput.getAttribute('max')
-    const STEP = Number(counterInput.getAttribute('step'))
+    const step = Number(counterInput.getAttribute('step'))
 
     btnUp.removeAttribute('disabled', '')
     btnDown.removeAttribute('disabled', '')
 
-    if (Number(counterInput.value) - STEP < min) {
+    if (Number(counterInput.value) - step < min) {
       btnDown.setAttribute('disabled', '')
     }
 
-    if (Number(counterInput.value) + STEP > max) {
+    if (Number(counterInput.value) + step > max) {
       btnUp.setAttribute('disabled', '')
     }
   }

diff --git a/scss/_variables.scss b/scss/_variables.scss
@@ -936,14 +936,14 @@ $form-label-disabled-color:             $gray-500 !default; // Boosted mod
 // scss-docs-start form-input-variables
 $input-padding-y:                       $input-btn-padding-y !default;
 $input-padding-x:                       $spacer * .5 !default;
-$input-padding-y-sm:                    divide($input-padding-y, 2) !default;
-$input-padding-x-sm:                    divide($input-padding-y, 2) !default;
 $input-font-family:                     $input-btn-font-family !default;
 $input-font-size:                       $input-btn-font-size !default;
 $input-font-weight:                     $font-weight-bold !default;
 $input-line-height:                     $input-btn-line-height !default;
 
-// Boosted mod: no input-sm
+$input-padding-y-sm:                    divide($input-padding-y, 2) !default; // Boosted mod
+$input-padding-x-sm:                    divide($input-padding-y, 2) !default; // Boosted mod
+// Boosted mod: no $input-font-size-sm
 
 $input-padding-y-lg:                    $input-btn-padding-y-lg !default;
 $input-padding-x-lg:                    $input-btn-padding-x-lg !default;
@@ -975,15 +975,13 @@ $input-plaintext-color:                 $body-color !default;
 // Boosted mod: no $input-height-inner-*
 
 $input-height:                          2.5rem !default;
-// Boosted mod: no input-sm
+// Boosted mod: no $input-height-sm
 $input-height-lg:                       3.125rem !default;
 $input-line-height-lg:                  $h5-line-height !default; // Boosted mod
 
 $input-transition:                      border-color $transition-duration $transition-timing, $transition-focus !default;
 
 $form-color-width:                      3rem !default;
-// End mod
-
 // scss-docs-end form-input-variables
 
 // scss-docs-start form-check-variables