-
-
Notifications
You must be signed in to change notification settings - Fork 399
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
APNG Exporter #772
APNG Exporter #772
Conversation
This was the testbed of the previous integration commits.
Hello! I request you to move this code into an Godot addon so that it can be maintained independently from Pixelorama and will also help other Godot Projects! You can reference the GIF exporter addon as template. |
If I'm moving the APNG export code into a Godot addon, does that mean I should migrate it to https://gitlab.com/20kdc/20kdc_godot_addons ? How does upstreaming/downstreaming interact with Pixelorama? |
If you want to make it a separate addon so other Godot projects can use it, you can put it on a repository on your own wherever you want to host it. There is no automatic downstream interaction, we basically just copy the files from the repository into Pixelorama's repository inside the Of course, this is optional and we only recommend doing it so other projects can use the exporter. If you don't want to make it an addon of its own, the current file organization works just fine. |
If the APNG exporter were more than a single file, I'd agree with the assessment to put it into an addon. As it is, however, I feel like more effort would be spent providing the necessary separation between addon and Pixelorama than it would take for anyone interested to copy it out. If there is a method I would recommend to achieve this, it would be to work with |
So hopefully I have managed to fix the format/linting issues with this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. I tested it a bit and couldn't find any issues, so I think it should be good to merge. Don't worry too much about formatting/linting, if it's an issue I can handle that for you, although the errors seem to have been fixed now.
Thanks! I will review your other pull request soon as well.
This allows exporting animations in the APNG format (which doesn't have the palette or transparency limitations of GIF).
It also cleans up the internals to allow adding more animation export formats easily.
The main UI change is making the export file format selector actually usable to select file formats.
Test example of exported output: