Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

APNG Exporter #772

Merged
merged 9 commits into from
Oct 30, 2022
Merged

APNG Exporter #772

merged 9 commits into from
Oct 30, 2022

Conversation

20kdc
Copy link
Contributor

@20kdc 20kdc commented Oct 27, 2022

This allows exporting animations in the APNG format (which doesn't have the palette or transparency limitations of GIF).
It also cleans up the internals to allow adding more animation export formats easily.

The main UI change is making the export file format selector actually usable to select file formats.

Test example of exported output:
loader

@dphaldes
Copy link
Contributor

Hello! I request you to move this code into an Godot addon so that it can be maintained independently from Pixelorama and will also help other Godot Projects! You can reference the GIF exporter addon as template.

@20kdc
Copy link
Contributor Author

20kdc commented Oct 28, 2022

If I'm moving the APNG export code into a Godot addon, does that mean I should migrate it to https://gitlab.com/20kdc/20kdc_godot_addons ? How does upstreaming/downstreaming interact with Pixelorama?
Or do I simply need to separate it out for file organization purposes?

@OverloadedOrama
Copy link
Member

If you want to make it a separate addon so other Godot projects can use it, you can put it on a repository on your own wherever you want to host it. There is no automatic downstream interaction, we basically just copy the files from the repository into Pixelorama's repository inside the addon folder, pretty much the same way as to how addons are being downloaded from Godot's Asset Store and integrated in the project's files, and we put the licenses and version for each addon in we use in the readme file inside the addons folder.

Of course, this is optional and we only recommend doing it so other projects can use the exporter. If you don't want to make it an addon of its own, the current file organization works just fine.

@20kdc
Copy link
Contributor Author

20kdc commented Oct 28, 2022

If the APNG exporter were more than a single file, I'd agree with the assessment to put it into an addon.

As it is, however, I feel like more effort would be spent providing the necessary separation between addon and Pixelorama than it would take for anyone interested to copy it out.
I made sure that it's not particularly coupled to Pixelorama in the first place.

If there is a method I would recommend to achieve this, it would be to work with gdgifexporter to work out how to make an abstraction layer between formats at that addon's level, and therefore expand that addon's scope to include APNG.

@20kdc
Copy link
Contributor Author

20kdc commented Oct 30, 2022

So hopefully I have managed to fix the format/linting issues with this PR

Copy link
Member

@OverloadedOrama OverloadedOrama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I tested it a bit and couldn't find any issues, so I think it should be good to merge. Don't worry too much about formatting/linting, if it's an issue I can handle that for you, although the errors seem to have been fixed now.

Thanks! I will review your other pull request soon as well.

@OverloadedOrama OverloadedOrama merged commit 82acf3f into Orama-Interactive:master Oct 30, 2022
@20kdc 20kdc mentioned this pull request Dec 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants