Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create installer #486

Merged
merged 3 commits into from
May 21, 2021
Merged

Create installer #486

merged 3 commits into from
May 21, 2021

Conversation

huskeee
Copy link
Contributor

@huskeee huskeee commented May 18, 2021

Created a multilingual multiarch installer using NSIS.

huskeee added 3 commits May 7, 2021 05:20
Fixed NSIS localization scripts, app version and added file association creation on installation
Finalized installer and NSIS localization scripts, added pxo document icon
Added installer build and upload to release workflow
#. DESC_un.SecConfig
#: ../pixelorama.nsi:206
msgid "Removes configuration files for ${APPNAME}."
msgstr ""
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I might be wrong but this seems like it's the same file as the one in installer/installer.pot. Does it have to be in both places?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not really, this is exactly the same file as installer/installer.pot. Probably forgot it there while testing.

Copy link
Member

@OverloadedOrama OverloadedOrama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@OverloadedOrama OverloadedOrama merged commit 0b1f035 into Orama-Interactive:master May 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants