Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow moving the canvas and zooming with the touchpad #391

Merged
merged 1 commit into from
Dec 5, 2020

Conversation

Schweini07
Copy link
Contributor

Please look at #390 before, I explained the gestures there.
Now zooming trough panning is replaced with moving the canvas through panning.

Fixes #271(?)

@OverloadedOrama
Copy link
Member

I don't think it solves #271, since it's asking for scrollbars that can also be used with the mouse and this PR is only about touch controls. Still though, it looks nice and I'll test it later. Does it work for mobile devices (and touch displays in general) too?

@Schweini07
Copy link
Contributor Author

I think those Input commands are only for laptop touchpads, but maybe it works?!

And the possible fix for #271 is because of this comment from the issue author:
As an FYI:
Mac doesn't have clickble middle button. It has Left click, Right click and touch slide ( acts like middle scroll wheel of mouse) https://youtu.be/qn6fz_6_fcw?t=178

For example with ASE I can touch slide up/down/left/right and scrolls the viewport. Actually this happens for any application scroll bars appear including Pixelorama.

@Schweini07
Copy link
Contributor Author

Looking at the InputEventGesture class it states:
Base class for touch control gestures.
So it probably works on mobile.

Copy link
Member

@OverloadedOrama OverloadedOrama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay! Looks good to me. Thank you!

@OverloadedOrama OverloadedOrama merged commit e0b0108 into Orama-Interactive:master Dec 5, 2020
@OverloadedOrama
Copy link
Member

OverloadedOrama commented Dec 5, 2020

Ah, I did some more research and looks like this change will only affect the macOS platform. godotengine/godot#13139

There's an open PR in Godot to make them work for all platforms though, so let's cross our fingers that it'll get merged and wait for Godot 4.0 :D

EDIT: Oh, there's another open PR for the 3.2 branch, so mayyybe 3.2.4 or 3.2.5?

@Schweini07
Copy link
Contributor Author

What a pity.
Well with luck waiting for Godot 3.2.4 or 3.2.5 it's implemented!

@Schweini07 Schweini07 deleted the pan-zoom branch December 5, 2020 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Scrollbars for image panning
2 participants