Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow multiple Grids #1122

Merged
merged 8 commits into from
Nov 25, 2024
Merged

Allow multiple Grids #1122

merged 8 commits into from
Nov 25, 2024

Conversation

Variable-ind
Copy link
Contributor

  • The next grid is drawn over the previous grid so first draw a smaller grid, then a bigger grid and so on
  • Snapping is done by the grid at layer zero (In the future we may allow snapping to all grids but for now, bear with me)
  • Maximum 10 layers are allowed

Testing is required

UI-.3.mp4

OverloadedOrama
OverloadedOrama approved these changes Nov 25, 2024
View reviewed changes
Copy link
Member

@OverloadedOrama OverloadedOrama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Did some testing and couldn't find any issues. Thank you!

@OverloadedOrama OverloadedOrama merged commit 6224d06 into Orama-Interactive:master Nov 25, 2024
4 checks passed
@Variable-ind Variable-ind deleted the grids branch November 25, 2024 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OverloadedOrama OverloadedOrama OverloadedOrama approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Variable-ind @OverloadedOrama