OY-4717 turhia testejä pois, koodisto-kirjastoriippuvuus pois

Opetushallitus · Jan 8, 2025 · 627465c · 627465c
1 parent 9f59239
commit 627465c
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 41 deletions.
diff --git a/pom.xml b/pom.xml
@@ -220,11 +220,6 @@
             <artifactId>jackson-annotations</artifactId>
             <version>${jackson.version}</version>
         </dependency>
-<!--        <dependency>-->
-<!--            <groupId>com.fasterxml.jackson.core</groupId>-->
-<!--            <artifactId>jackson-databind</artifactId>-->
-<!--            <version>${jackson.version}</version>-->
-<!--        </dependency>-->
         <!-- scala-cas-depsut-->
         <dependency>
             <groupId>org.scala-lang.modules</groupId>
@@ -272,11 +267,6 @@
             <artifactId>db-scheduler</artifactId>
             <version>5.2</version>
         </dependency>
-        <dependency>
-            <groupId>fi.vm.sade.koodisto</groupId>
-            <artifactId>koodisto-api</artifactId>
-            <version>2019-06-SNAPSHOT</version>
-        </dependency>
         <dependency>
             <groupId>com.sun.jersey</groupId>
             <artifactId>jersey-client</artifactId>

diff --git a/src/test/scala/fi/vm/sade/omatsivut/hakemus/GetApplicationsSpec.scala b/src/test/scala/fi/vm/sade/omatsivut/hakemus/GetApplicationsSpec.scala
@@ -1,7 +1,6 @@
 package fi.vm.sade.omatsivut.hakemus
 
 import fi.vm.sade.omatsivut.{PersonOid, TimeWarp}
-import fi.vm.sade.omatsivut.fixtures.TestFixture
 import fi.vm.sade.omatsivut.fixtures.TestFixture._
 import org.junit.runner.RunWith
 import org.specs2.runner.JUnitRunner
@@ -14,6 +13,7 @@ class GetApplicationsSpec extends HakemusApiSpecification with FixturePerson wit
   sequential
 
   "GET /applications" should {
+//    TODO fix fai delete?
 //    "return person's applications" in {
 //      withApplicationsResponse { resp =>
 //        resp.allApplicationsFetched must_== true
@@ -30,35 +30,5 @@ class GetApplicationsSpec extends HakemusApiSpecification with FixturePerson wit
       }(PersonOid(personOidWithAtaru))
     }
 
-//    "tell for basic application that no additional info is required" in {
-//      withHakemusWithEmptyAnswers(hakemusNivelKesa2013WithPeruskouluBaseEducationId) { hakemusInfo =>
-//        hakemusInfo.hakemus.requiresAdditionalInfo must_== false
-//      }
-//    }
-//
-//    "tell for dance education application that additional info is required" in {
-//      withHakemusWithEmptyAnswers(TestFixture.hakemusWithGradeGridAndDancePreference) { hakemusInfo =>
-//        hakemusInfo.hakemus.requiresAdditionalInfo must_== true
-//      }
-//    }
-//
-//    "tell for discretionary application that additional info is required" in {
-//      withHakemusWithEmptyAnswers(hakemusYhteishakuKevat2014WithForeignBaseEducationId) { hakemusInfo =>
-//        hakemusInfo.hakemus.requiresAdditionalInfo must_== true
-//      }
-//    }
-//
-//    "use application system's application period when application type is not 'LISÄHAKU'" in {
-//      withHakemusWithEmptyAnswers(hakemusYhteishakuKevat2014WithForeignBaseEducationId) { hakemusInfo =>
-//        hakemusInfo.hakemus.haku.get.applicationPeriods.head must_== TestFixture.hakemus2_hakuaika
-//      }
-//    }
-//    "provide additional application period for application with athlete questions" in {
-//      withHakemusWithEmptyAnswers(hakemusWithAtheleteQuestions) { hakemusInfo =>
-//        val aika = hakemusInfo.hakemus.hakutoiveet.head.hakukohdekohtaisetHakuajat.get.head
-//        aika.start must_== 1404290831839L
-//        aika.end must beSome(4507513600000L)
-//      }
-//    }
   }
 }