feat(shared-data): add deck schema v6 #17250
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This schema contains a concept of "locating features" for addressable areas. These locating features are things that constrain the position of labware loaded on top of the addressable area. The presence of a locating feature indicates that the addressable area can contain deck items. Which locating feature is available constrains which labware can be loaded; different labware define different locatable features (for instance, their back left or front left corners, or the outer surface of one of their wells). Locating feature names are not constrained to enums because we expect a fairly wide number of them. Closes EXEC-80
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## edge #17250 +/- ##
==========================================
+ Coverage 73.84% 74.04% +0.20%
==========================================
Files 43 43
Lines 3303 3329 +26
==========================================
+ Hits 2439 2465 +26
Misses 864 864
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Remove the duplicate entry for v4 and add the missing entries for v5 and v6. This appears unused, but we may as well correct it.
This has a matingSurfaceUnitVector field, which does not exist in schema 6. Rename the type so it doesn't look more generally usable than it actually is.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This schema contains a concept of "locating features" for addressable areas. These locating features are things that constrain the position of labware loaded on top of the addressable area. The presence of a locating feature indicates that the addressable area can contain deck items. Which locating feature is available constrains which labware can be loaded; different labware define different locatable features (for instance, their back left or front left corners, or the outer surface of one of their wells).
Locating feature names are not constrained to enums because we expect a fairly wide number of them.
To come out of draft
risk
low, because nothing should be using this (purposeful, will be followup prs)
Closes EXEC-80