Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(app-shell): remove postinstall and patch #11785

Merged

Conversation

koji
Copy link
Contributor

@koji koji commented Nov 28, 2022

Overview

update nan version manually to avoid the error and remove postinstall and patch from package.json

Changelog

Review requests

Risk assessment

low

@koji
Copy link
Contributor Author

koji commented Nov 28, 2022

@koji koji changed the title Chore remove postinstall and patch chore(app-shell): remove postinstall and patch Nov 28, 2022
@codecov
Copy link

codecov bot commented Nov 28, 2022

Codecov Report

Merging #11785 (f36c0ce) into edge (989ab1d) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             edge   #11785   +/-   ##
=======================================
  Coverage   74.14%   74.14%           
=======================================
  Files        2105     2105           
  Lines       58480    58480           
  Branches     6215     6215           
=======================================
  Hits        43360    43360           
  Misses      13654    13654           
  Partials     1466     1466           
Flag Coverage Δ
app 72.58% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@koji koji marked this pull request as ready for review November 29, 2022 00:40
@koji koji requested review from a team as code owners November 29, 2022 00:40
@koji koji requested review from jerader and removed request for a team November 29, 2022 00:40
@koji koji marked this pull request as draft November 29, 2022 00:41
@koji koji removed request for a team and jerader November 29, 2022 00:41
@koji koji added the blocked Ticket or PR is blocked by other work label Nov 29, 2022
@koji koji changed the base branch from edge to chore_update-electron-minor-update November 29, 2022 03:58
@koji koji marked this pull request as ready for review November 29, 2022 04:00
@koji koji removed the blocked Ticket or PR is blocked by other work label Nov 29, 2022
@koji koji merged commit e1b4549 into chore_update-electron-minor-update Nov 29, 2022
@koji koji deleted the chore_remove-postinstall-and-patch branch January 9, 2023 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant