chore(app-shell): Upgrade the Electron version to 21

.github/workflows/api-test-lint-deploy.yaml

@@ -54,7 +54,7 @@ jobs:
       - uses: 'actions/checkout@v3'
       - uses: 'actions/setup-node@v3'
         with:
-          node-version: '14'
+          node-version: '16'
       - uses: 'actions/setup-python@v4'
         with:
           python-version: '3.7'
@@ -89,7 +89,7 @@ jobs:
       - uses: 'actions/checkout@v3'
       - uses: 'actions/setup-node@v3'
         with:
-          node-version: '14'
+          node-version: '16'
       - uses: 'actions/setup-python@v4'
         with:
           python-version: ${{ matrix.python }}
@@ -131,7 +131,7 @@ jobs:
       - uses: 'actions/checkout@v3'
       - uses: 'actions/setup-node@v3'
         with:
-          node-version: '14'
+          node-version: '16'
       - uses: 'actions/setup-python@v4'
         with:
           python-version: '3.7'

.github/workflows/app-test-build-deploy.yaml

@@ -57,7 +57,7 @@ jobs:
       - uses: 'actions/checkout@v3'
       - uses: 'actions/setup-node@v3'
         with:
-          node-version: '14'
+          node-version: '16'
       - name: 'install udev'
         run: sudo apt-get update && sudo apt-get install libudev-dev
       - name: 'set complex environment variables'
@@ -93,18 +93,20 @@ jobs:
     # to run cross-platform just like builds, might as well do them in the same job
     strategy:
       matrix:
-        os: ['windows-2019', 'ubuntu-22.04', 'macos-latest']
+        os: ['windows-2022', 'ubuntu-22.04', 'macos-latest']
     name: 'opentrons app backend unit tests and build'
     needs: ['js-unit-test']
     runs-on: ${{ matrix.os }}
     steps:
       - uses: 'actions/checkout@v3'
       - uses: 'actions/setup-node@v3'
         with:
-          node-version: '14'
+          node-version: '16'
       - uses: actions/setup-python@v4
         with:
           python-version: '3.10'
+      - name: 'downgrade npm version'
+        run: npm install -g npm@6
       - name: 'install libudev'
         if: startsWith(matrix.os, 'ubuntu')
         run: sudo apt-get update && sudo apt-get install libudev-dev
@@ -150,8 +152,14 @@ jobs:
           APPLE_ID: ${{ secrets.OT_APP_APPLE_ID }}
           APPLE_ID_PASSWORD: ${{ secrets.OT_APP_APPLE_ID_PASSWORD }}
           HOST_PYTHON: python
+        # TODO kj 10/17/2022 this run will be used make -C when all issues are solved.
         run: |
-          make -C app-shell dist-${{ matrix.os }}
+          if [ '${{ matrix.os}}' == 'ubuntu-22.04']
+          then
+            make -C app-shell dist-${{ matrix.os }}
+          else
+            CPPFLAGS="-std=c++17" make -C app-shell dist-${{ matrix.os }}
+          fi
 
       - if: github.event_name != 'pull_request'
         name: 'upload github artifact'

.github/workflows/components-test-build-deploy.yaml

@@ -42,7 +42,7 @@ jobs:
       - uses: 'actions/checkout@v3'
       - uses: 'actions/setup-node@v3'
         with:
-          node-version: '14'
+          node-version: '16'
       - name: 'install udev for usb-detection'
         run: sudo apt-get update && sudo apt-get install libudev-dev
       - name: 'cache yarn cache'
@@ -77,7 +77,7 @@ jobs:
       - uses: 'actions/checkout@v3'
       - uses: 'actions/setup-node@v3'
         with:
-          node-version: '14'
+          node-version: '16'
       - name: 'install udev for usb-detection'
         run: sudo apt-get update && sudo apt-get install libudev-dev
       - name: 'cache yarn cache'
@@ -110,7 +110,7 @@ jobs:
       - uses: 'actions/checkout@v3'
       - uses: 'actions/setup-node@v3'
         with:
-          node-version: '14'
+          node-version: '16'
       - name: 'set complex environment variables'
         id: 'set-vars'
         uses: actions/github-script@v6.1.1

.github/workflows/docs-build.yaml

@@ -7,7 +7,6 @@
 #   * The docs source themselves;
 #   * The CI/makefile tooling used to build the docs.
 
-
 name: 'API docs build'
 
 on:
@@ -44,7 +43,7 @@ jobs:
       - uses: 'actions/checkout@v3'
       - uses: 'actions/setup-node@v3'
         with:
-          node-version: '14'
+          node-version: '16'
       - uses: 'actions/setup-python@v3'
         with:
           python-version: '3.7'

.github/workflows/js-check.yaml

@@ -45,7 +45,7 @@ jobs:
       - uses: 'actions/checkout@v3'
       - uses: 'actions/setup-node@v3'
         with:
-          node-version: '14'
+          node-version: '16'
       - name: 'set complex environment variables'
         id: 'set-vars'
         uses: actions/github-script@v6.1.1
@@ -70,7 +70,7 @@ jobs:
           npm config set cache ${{ github.workspace }}/.npm-cache
           yarn config set cache-folder ${{ github.workspace }}/.yarn-cache
           make setup-js
-      # Use the if to run all the lint checks even of some fail
+        # Use the if to run all the lint checks even of some fail
         shell: bash
       - name: 'lint js'
         if: always() && steps.setup-js.outcome == 'success'

.github/workflows/ll-test-build-deploy.yaml

@@ -45,7 +45,7 @@ jobs:
       - uses: 'actions/checkout@v3'
       - uses: 'actions/setup-node@v3'
         with:
-          node-version: '14'
+          node-version: '16'
       - name: 'install libudev for usb-detection'
         run: sudo apt-get update && sudo apt-get install libudev-dev
       - name: 'cache yarn cache'
@@ -80,7 +80,7 @@ jobs:
       - uses: 'actions/checkout@v3'
       - uses: 'actions/setup-node@v3'
         with:
-          node-version: '14'
+          node-version: '16'
       - name: 'install libudev for usb-detection'
         run: sudo apt-get update && sudo apt-get install libudev-dev
       - name: 'cache yarn cache'
@@ -111,7 +111,7 @@ jobs:
       - uses: 'actions/checkout@v3'
       - uses: 'actions/setup-node@v3'
         with:
-          node-version: '14'
+          node-version: '16'
       - name: 'install libudev for usb-detection'
         run: sudo apt-get update && sudo apt-get install libudev-dev
       - name: 'cache yarn cache'
@@ -148,7 +148,7 @@ jobs:
       - uses: 'actions/checkout@v3'
       - uses: 'actions/setup-node@v3'
         with:
-          node-version: '14'
+          node-version: '16'
       - name: 'install udev for usb-detection'
         run: sudo apt-get update && sudo apt-get install libudev-dev
       - name: 'set complex environment variables'

.github/workflows/notify-server-lint-test.yaml

@@ -49,7 +49,7 @@ jobs:
       - uses: 'actions/checkout@v3'
       - uses: 'actions/setup-node@v3'
         with:
-          node-version: '14'
+          node-version: '16'
       - uses: 'actions/setup-python@v4'
         with:
           python-version: '3.7'

.github/workflows/pd-test-build-deploy.yaml

@@ -47,7 +47,7 @@ jobs:
       - uses: 'actions/checkout@v3'
       - uses: 'actions/setup-node@v3'
         with:
-          node-version: '14'
+          node-version: '16'
       - name: 'install udev for usb-detection'
         run: sudo apt-get update && sudo apt-get install libudev-dev
       - name: 'cache yarn cache'
@@ -85,7 +85,7 @@ jobs:
       - uses: 'actions/checkout@v3'
       - uses: 'actions/setup-node@v3'
         with:
-          node-version: '14'
+          node-version: '16'
       - name: 'install udev for usb-detection'
         if: startsWith(matrix.os, 'ubuntu')
         run: sudo apt-get update && sudo apt-get install libudev-dev
@@ -114,7 +114,7 @@ jobs:
       - uses: 'actions/checkout@v3'
       - uses: 'actions/setup-node@v3'
         with:
-          node-version: '14'
+          node-version: '16'
       - name: 'install udev for usb-detection'
         run: sudo apt-get update && sudo apt-get install libudev-dev
       - name: 'cache yarn cache'
@@ -151,7 +151,7 @@ jobs:
       - uses: 'actions/checkout@v3'
       - uses: 'actions/setup-node@v3'
         with:
-          node-version: '14'
+          node-version: '16'
       - name: 'install udev for usb-detection'
         run: sudo apt-get update && sudo apt-get install libudev-dev
       - name: 'set complex environment variables'

.github/workflows/react-api-client-test.yaml

@@ -39,7 +39,7 @@ jobs:
       - uses: 'actions/checkout@v3'
       - uses: 'actions/setup-node@v3'
         with:
-          node-version: '14'
+          node-version: '16'
       - name: 'install libudev for usb-detection'
         run: sudo apt-get update && sudo apt-get install libudev-dev
       - name: 'cache yarn cache'

.github/workflows/robot-server-lint-test.yaml

@@ -59,7 +59,7 @@ jobs:
       - uses: 'actions/checkout@v3'
       - uses: 'actions/setup-node@v3'
         with:
-          node-version: '14'
+          node-version: '16'
       - uses: 'actions/setup-python@v4'
         with:
           python-version: '3.7'

.github/workflows/shared-data-test-lint-deploy.yaml

@@ -47,7 +47,7 @@ jobs:
       - uses: 'actions/checkout@v3'
       - uses: 'actions/setup-node@v3'
         with:
-          node-version: '14'
+          node-version: '16'
       - uses: 'actions/setup-python@v3'
         with:
           python-version: '3.7'
@@ -79,7 +79,7 @@ jobs:
         run: sudo apt-get update && sudo apt-get install libudev-dev
       - uses: 'actions/setup-node@v1'
         with:
-          node-version: '14'
+          node-version: '16'
       - uses: 'actions/setup-python@v4'
         with:
           python-version: ${{ matrix.python }}
@@ -111,7 +111,7 @@ jobs:
       - uses: 'actions/checkout@v3'
       - uses: 'actions/setup-node@v3'
         with:
-          node-version: '14'
+          node-version: '16'
       - name: 'install udev'
         run: sudo apt-get update && sudo apt-get install libudev-dev
       - name: 'cache yarn cache'
@@ -146,7 +146,7 @@ jobs:
       - uses: 'actions/checkout@v3'
       - uses: 'actions/setup-node@v3'
         with:
-          node-version: '14'
+          node-version: '16'
       - name: 'install udev for usb-detection'
         run: sudo apt-get update && sudo apt-get install libudev-dev
       - uses: 'actions/setup-python@v4'

.github/workflows/step-generation-test.yaml

@@ -40,7 +40,7 @@ jobs:
       - uses: 'actions/checkout@v3'
       - uses: 'actions/setup-node@v3'
         with:
-          node-version: '14'
+          node-version: '16'
       - name: 'install udev for usb-detection'
         run: sudo apt-get update && sudo apt-get install libudev-dev
       - name: 'cache yarn cache'

.github/workflows/update-server-lint-test.yaml

@@ -44,7 +44,7 @@ jobs:
       - uses: 'actions/checkout@v3'
       - uses: 'actions/setup-node@v3'
         with:
-          node-version: '14'
+          node-version: '16'
       - uses: 'actions/setup-python@v4'
         with:
           python-version: '3.7'
@@ -63,7 +63,7 @@ jobs:
       - uses: 'actions/checkout@v3'
       - uses: 'actions/setup-node@v3'
         with:
-          node-version: '14'
+          node-version: '16'
       - uses: 'actions/setup-python@v4'
         with:
           python-version: '3.7'

.github/workflows/usb-bridge-lint-test.yaml

@@ -44,7 +44,7 @@ jobs:
       - uses: 'actions/checkout@v3'
       - uses: 'actions/setup-node@v3'
         with:
-          node-version: '14'
+          node-version: '16'
       - uses: 'actions/setup-python@v4'
         with:
           python-version: '3.7'
@@ -63,7 +63,7 @@ jobs:
       - uses: 'actions/checkout@v3'
       - uses: 'actions/setup-node@v3'
         with:
-          node-version: '14'
+          node-version: '16'
       - uses: 'actions/setup-python@v4'
         with:
           python-version: '3.7'

.nvmrc

@@ -1 +1 @@
-14
+16

DEV_SETUP.md

@@ -13,7 +13,7 @@ You will need the following tools installed to develop on the Opentrons platform
 - curl
 - ssh
 - Python v3.7
-- Node.js v14
+- Node.js v16
 
 ### macOS
 
@@ -63,7 +63,7 @@ If you haven't used `git` before, **be sure to complete [first-time Git setup][]
 
 Our recommended installation instructions for Node.js differ between `x86_64` (Intel) and `ARM` (M1) Macs.
 
-##### x86-64 Mac (Intel)
+##### x86-64 Mac (Intel) & ARM Mac(M1)
 
 On x86, we recommend [nvs][] to install Node.js because it works well and is compatible with macOS, Windows, and Linux.
 
@@ -85,7 +85,7 @@ nvs --version
 Now we can use nvs to install Node.js v14 and switch on `auto` mode, which will make sure Node.js v14 is used any time we're in the `opentrons` project directory.
 
 ```shell
-nvs add 14
+nvs add 16
 nvs auto on
 ```
 
@@ -99,38 +99,6 @@ export NVS_HOME="$HOME/.nvs"
 # ...
 ```
 
-##### ARM Mac (M1)
-
-If you are running an ARM (M1) Mac, you **should not use `nvs` nor `nvm`**, because those tools do not have access to Node.js v14 for the ARM architecture. Until we upgrade to version 16 or higher, you need to use an alternative installation method for Node.js.
-
-Fortunately, you can use `brew` to install an ARM-native version of Node v14.
-
-```shell
-brew install node@14
-```
-
-Once `brew` finishes installing Node, it will print one additional step to complete the installation to ensure your system selects the proper Node executable to use.
-
-```shell
-echo 'export PATH="/opt/homebrew/opt/node@14/bin:$PATH"' >> ~/.zshrc
-```
-
-Close and re-open your terminal to confirm that the correct version of Node is installed for the correct architecture.
-
-```shell
-node -e "console.log(process.version, process.arch)"
-# > v14.19.1 arm64
-```
-
-If your `node` command isn't working or is printing the wrong information, confirm that your shell is set up properly. If you print out the contents of `~/.zshrc`, you should see something similar to the following:
-
-```shell
-# ~/.zshrc
-# ...
-export PATH="/opt/homebrew/opt/node@14/bin:$PATH"
-# ...
-```
-
 #### 2. Install `pyenv` and Python
 
 On macOS, we recommend [pyenv][] to install different versions of Python.