Fix Buidler deployProxy for overloaded initializers #149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 31, 2020
martriay
suggested changes
Aug 31, 2020
| } | ||
|
|
||
| // We recommend this pattern to be able to use async/await everywhere | ||
| // and properly handle errors. |
There was a problem hiding this comment.
I find this comment borrowed from Buidler examples a bit confusing, it seems written by us but it's not, nor it is clarifying. I suggest we remove it.
There was a problem hiding this comment.
I removed it from the test I introduced in this PR. We should remove it from everywhere else afterwards.
martriay
approved these changes
Aug 31, 2020
|
Looks good thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #146.
We were only allowing initializer names, which doesn't work with overloading. This PR changes the implementation to use the native
Interface.getFunctionfunction provided by Ethers, which supports all of: names, signatures, and selectors.cc @abcoathup: This should be reflected in the API docs which I didn't edit in this PR because we moved them to another file in the
docsbranch (#142). See Specifying Fragments in the Ethers documentation for the different ways initializers can be specified.