Fix fetchERC721
#5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove re-declaration of `contract`, so that the newly created instance is returned by the function.
|
Thank you for finding this! |
freeatnet
referenced
this pull request
Aug 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove re-declaration of
contract, so that the newly created instance is returned by the function.This bug manifests itself as the subgraph failing to index transfer events.
Steps to reproduce the bug
Expected
erc721Contractsreturns the deployed contract, along with its name and symbol;erc721Transfersfield returns minting transactions;accounts.ERC721tokensandaccounts.ERC721transferToEventfields are populated appropriately.Observed
erc721Contractsreturns the deployed contract, along with its name and symbol; however,erc721Transfers,accounts.ERC721tokens, andaccounts.ERC721transferToEventare empty.