Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #1346
With this PR, there is only one warning remaining, which we can't get rid of yet (unless we add a dummy state variable read, but while this may be fine for a mock, I don't think it is for actual production code):
It's probably best to review each commit separately.
Regarding the changes:
PaymentSplitter#_addPayee
Roles
(which works on aRole
) andArrays
(which works on an array)