-
Notifications
You must be signed in to change notification settings - Fork 11.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add generic TimeFrame contract for time life cycles #1592
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking great @Sonblind, thanks a lot! I left a couple minor comments, and some suggestions on how to get the tests to work. We may also want to move the library to the drafts
directory for now, until we've had more time to think about it and commit to a stable API.
Regarding naming, I'm not sure 'epoch' fits: isn't an epoch typically a single point in time? I think we could just go with library TimeFrames struct TimeFrame
(the same approach we took in Arrays
, Roles
, and Counters
).
Hey there @Sonblind! This is in quite a good place, but due to time constraints we're delaying the inclusion of this until v2.3 (which should be in a couple weeks). |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Hey there @Sonblind! Are you still interested in working on this? If not, I can finish the PR on my own by committing on top of yours, keeping proper attribution. Thanks! |
Hey Nicolas,
Thanks for following up on this. I know it’s been a minute since I last touched it. I may be able to get to it this week, or at the latest the weekend.
Sam
…On Mar 18, 2019, at 11:38 AM, Nicolás Venturo ***@***.***> wrote:
Hey there @Sonblind! Are you still interested in working on this? If not, I can finish the PR on my own by committing on top of yours, keeping proper attribution. Thanks!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
|
No worries :) |
hey guys what's up |
Hey there @startgeek, thank you for your initiative! It looks like @Sonblind may be too busy, so I think it'd be fine for you to open a pull request (PR) from your fork. You can do that here (select the branch you want to open the pull request from). |
Thanks guys. I wish I had time to update this but have been very busy. Have at it, @startgeek 👍🏽 |
Closing this PR in favor of #1706. |
Add
TimeFrame
contract for time-based lifecycles.Some of the other examples I have seen are specific to escrows, or tokens.
Leasable
is a high level lifecycle contract.This is my first contribution. Please forgive me if I'm going about this the wrong way.