Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add generic TimeFrame contract for time life cycles #1592

Closed
wants to merge 1 commit into from
Closed

Add generic TimeFrame contract for time life cycles #1592

wants to merge 1 commit into from

Conversation

DoubleOTheven
Copy link

@DoubleOTheven DoubleOTheven commented Jan 6, 2019

Add TimeFrame contract for time-based lifecycles.

Some of the other examples I have seen are specific to escrows, or tokens. Leasable is a high level lifecycle contract.

This is my first contribution. Please forgive me if I'm going about this the wrong way.

@nventuro nventuro added this to the v2.2 milestone Jan 7, 2019
CHANGELOG.md Outdated Show resolved Hide resolved
@nventuro nventuro changed the title Add generic Leasable contract for time life cycles Add generic TimeFrame contract for time life cycles Jan 17, 2019
@nventuro nventuro added feature New contracts, functions, or helpers. contracts Smart contract code. labels Jan 17, 2019
@nventuro nventuro self-assigned this Jan 17, 2019
Copy link
Contributor

@nventuro nventuro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great @Sonblind, thanks a lot! I left a couple minor comments, and some suggestions on how to get the tests to work. We may also want to move the library to the drafts directory for now, until we've had more time to think about it and commit to a stable API.

Regarding naming, I'm not sure 'epoch' fits: isn't an epoch typically a single point in time? I think we could just go with library TimeFrames struct TimeFrame (the same approach we took in Arrays, Roles, and Counters).

CHANGELOG.md Show resolved Hide resolved
contracts/lifecycle/TimeFrame.sol Show resolved Hide resolved
contracts/lifecycle/TimeFrame.sol Show resolved Hide resolved
contracts/lifecycle/TimeFrame.sol Show resolved Hide resolved
contracts/lifecycle/TimeFrame.sol Show resolved Hide resolved
contracts/lifecycle/TimeFrame.sol Show resolved Hide resolved
contracts/mocks/TimeFrameMock.sol Show resolved Hide resolved
test/helpers/expectBNIsWithinDelta.js Show resolved Hide resolved
test/lifecycle/TimeFrame/TimeFrame.test.js Show resolved Hide resolved
test/lifecycle/TimeFrame/TimeFrame.test.js Show resolved Hide resolved
@nventuro nventuro modified the milestones: v2.2, v2.3 Jan 23, 2019
@nventuro
Copy link
Contributor

Hey there @Sonblind! This is in quite a good place, but due to time constraints we're delaying the inclusion of this until v2.3 (which should be in a couple weeks).

@stale
Copy link

stale bot commented Mar 18, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Mar 18, 2019
@nventuro
Copy link
Contributor

Hey there @Sonblind! Are you still interested in working on this? If not, I can finish the PR on my own by committing on top of yours, keeping proper attribution. Thanks!

@stale stale bot removed the stale label Mar 18, 2019
@DoubleOTheven
Copy link
Author

DoubleOTheven commented Mar 19, 2019 via email

@nventuro
Copy link
Contributor

No worries :)

@startgeek
Copy link

hey guys what's up
I did a fork on @Sonblind repo and fixed problems with the test's now it passes all (19) test's I really never contribute to any public project so what should I do now?

@nventuro
Copy link
Contributor

nventuro commented Apr 2, 2019

Hey there @startgeek, thank you for your initiative! It looks like @Sonblind may be too busy, so I think it'd be fine for you to open a pull request (PR) from your fork. You can do that here (select the branch you want to open the pull request from).

@DoubleOTheven
Copy link
Author

Thanks guys. I wish I had time to update this but have been very busy. Have at it, @startgeek 👍🏽

@nventuro
Copy link
Contributor

nventuro commented Apr 3, 2019

Closing this PR in favor of #1706.

@nventuro nventuro closed this Apr 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contracts Smart contract code. feature New contracts, functions, or helpers.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants