This repository has been archived by the owner on Jan 24, 2022. It is now read-only.
Rename examples #1096
Merged
Rename examples #1096
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Thanks for tackling this @spalladino 🚀! Left a couple of comments down below.
| @@ -7,7 +7,7 @@ | |||
| "scripts": { | |||
| "test": "scripts/test.sh" | |||
| }, | |||
| "author": "santiago@zeppelin.solutions", | |||
| "author": "santiago@openzeppelin.com", | |||
| This is a sample ZeppelinOS project that runs `zos` from truffle migrations, using the CLI javascript interface. | ||
| This allows any project that currently relies on truffle migrations to switch over to `zos`, thus deploying | ||
| upgradeable instances instead of regular ones. Also, by using the CLI interface, `zos` keeps track of all deployed | ||
| This is a sample OpenZeppelin SDK project that runs `openzeppelin` from truffle migrations, using the CLI javascript interface. |
There was a problem hiding this comment.
Suggested change
| This is a sample OpenZeppelin SDK project that runs `openzeppelin` from truffle migrations, using the CLI javascript interface. | |
| This is a sample of an OpenZeppelin SDK project that runs `openzeppelin` from truffle migrations, using the CLI javascript interface. |
Not sure though, feel free to dismiss the comment.
There was a problem hiding this comment.
I think both of them work: we are using OZ SDK both as a noun and as an adjective
| This allows any project that currently relies on truffle migrations to switch over to `zos`, thus deploying | ||
| upgradeable instances instead of regular ones. Also, by using the CLI interface, `zos` keeps track of all deployed | ||
| This is a sample OpenZeppelin SDK project that runs `openzeppelin` from truffle migrations, using the CLI javascript interface. | ||
| This allows any project that currently relies on truffle migrations to switch over to `openzeppelin`, thus deploying |
There was a problem hiding this comment.
Suggested change
| This allows any project that currently relies on truffle migrations to switch over to `openzeppelin`, thus deploying | |
| This allows any project that currently relies on truffle migrations to switch over to the`openzeppelin sdk`, thus deploying |
There was a problem hiding this comment.
I'm using openzeppelin to refer to the command-line tool, and OZ SDK (without backticks) to the full suite
| upgradeable instances instead of regular ones. Also, by using the CLI interface, `zos` keeps track of all deployed | ||
| This is a sample OpenZeppelin SDK project that runs `openzeppelin` from truffle migrations, using the CLI javascript interface. | ||
| This allows any project that currently relies on truffle migrations to switch over to `openzeppelin`, thus deploying | ||
| upgradeable instances instead of regular ones. Also, by using the CLI interface, `openzeppelin` keeps track of all deployed |
There was a problem hiding this comment.
Suggested change
| upgradeable instances instead of regular ones. Also, by using the CLI interface, `openzeppelin` keeps track of all deployed | |
| upgradeable instances instead of regular ones. Also, by using the CLI interface, the `openzeppelin sdk` keeps track of all deployed |
Co-Authored-By: Juan Bautista Carpanelli <juanbanelli@gmail.com>
|
Damn good review @jcarpanelli, thanks! I just applied most of the suggestions, re-review whenever you want! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.