Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement ControlledToken, contract owner can burn/mint tokens at will #796

Closed
wants to merge 1 commit into from
Closed

Implement ControlledToken, contract owner can burn/mint tokens at will #796

wants to merge 1 commit into from

Conversation

mjdietzx
Copy link

@mjdietzx mjdietzx commented Mar 6, 2018

Fixes #785 (issue was closed but this PR takes the suggestions received there)

🚀 Description

Another smart contract, or in some (rare) specific cases a centralized account, can burn/mint tokens from/to accounts at will. Other contracts may inherit this functionality to enable some use-cases where a controlled token is necessary

  • 📘 I've reviewed the OpenZeppelin Contributor Guidelines
  • ✅ I've added tests where applicable to test my new functionality.
  • 📖 I've made sure that my contracts are well-documented.
  • 🎨 I've run the JS/Solidity linters and fixed any issues (npm run lint:all:fix).

@liwei00wade
Copy link

this definitely doesn't belong in BurnableToken

Why ??

how to write a ControlledToken ?

@liwei00wade
Copy link

@nventuro
Copy link
Contributor

Closing due to staleness. Also, this can be easily achieved with _mint and _burn.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

📈 Make BurnableToken consistent w/ MintableToken (i.e. onlyOwner and burnFrom configurable)
3 participants